Re: [patch][4.7] Enhance XOR handling in simplify-rtx.c

2011-03-12 Thread Chung-Lin Tang
On 2011/3/11 10:14 PM, Chung-Lin Tang wrote: > Hi, > this patch adds a bit more sophistication to the handled xor RTX cases > in foo(). > > This may look a bit ad hoc, but I am seeing it useful for some cases > where we combine zero_extend with (not (shift ...)). The supplied ARM > testcase demon

[PATCH RFA]: clean up -fdiagnostics-show-option and -Werror= docs slightly

2011-03-12 Thread Chris Demetriou
-fdiagnostics-show-option is now the default, and it looks like neither its description or the -Werror= description was updated to match. This patch attempts to do that. tested by building, running nroff -man gcc.1, and reading the result. OK for trunk (i.e., pre-4.6)? (I feel a tiny bit bad ab

[fortran, doc] Fix doc for LOG intrinsic

2011-03-12 Thread FX
The attached patch clarifies the documentation of the LOG intrinsic by stating explicitly that it's the natural log function. Tested with "make info html pdf", OK to commit to trunk? FX log_doc.ChangeLog Description: Binary data log_doc.diff Description: Binary data

Re: [fortran, doc] Fix doc for LOG intrinsic

2011-03-12 Thread Tobias Burnus
Am 12.03.2011 10:52, schrieb FX: The attached patch clarifies the documentation of the LOG intrinsic by stating explicitly that it's the natural log function. Tested with "make info html pdf", OK to commit to trun I am mostly OK, however: function -@cindex logarithmic +@cindex base 10 logari

[fortran, committed] Fix CTIME code generation

2011-03-12 Thread FX
The patch below fixes PR 47552, where we generate a variable of wrong type for the string length argument passed to CTIME. Patch was approved in the PR, was regtested on x86_64-linux. Committed as revision 170898. 2011-03-12 Francois-Xavier Coudert PR fortran/47552 * trans-

Re: [fortran, doc] Fix doc for LOG intrinsic

2011-03-12 Thread FX
> I am mostly OK, however: > > function > -@cindex logarithmic > +@cindex base 10 logarithm function > > I think even when looking for the decadic logarithm (common logarithm), I > would look under "L" for logarithm and not under "B" for "base". How about > "logarithm function with base 10"? If

[Patch, Fortran, Regression] PR 48059: ICE in in gfc_conv_component_ref: character function of extended type

2011-03-12 Thread Janus Weil
Hi all, the attached patch fixes the PR in the subject line. The problem was the following: During the interface mapping for a procedure call we need to take special care of polymorphic arguments, since the type of the actual argument can differ from the type of the formal argument. Therefore we n

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-03-12 Thread Eric Botcazou
> gcc/ada/ > * gcc-interface/ada-tree.h (union lang_tree_node): Check for > TS_COMMON before calling TREE_CHAIN. > * gcc-interface/misc.c (gnat_init_ts): New function. > (LANG_HOOKS_INIT_TS): Define. I presume that PLUS_NOMOD_EXPR, MINUS_NOMOD_EXPR and ATTR_ADDR_EXPR need n

Re: [PATCH 17/18] introduce block_chainon and use BLOCK_CHAIN more

2011-03-12 Thread Eric Botcazou
> gcc/ada/ > * gcc-interface/utils.c (gnat_poplevel): Use block_chainon. OK, thanks. -- Eric Botcazou

[fortran, patch] Fix memory leak in arith_power()

2011-03-12 Thread FX
While looking at the use of gfc_free() in the front-end when discussing its removal, I noticed one instance where gfc_free_expr() should be used instead. The patch that fixes it is: 2011-03-12 Francois-Xavier Coudert * arith.c (arith_power): Plug memory leak. Index: arith.c ==

[libgfortran, patch] More than 26 temporary files with weak mktemp()

2011-03-12 Thread FX
The attached patch fixes half of PR 47439. On platform with weak or historical implementations of mktemp(), this function cannot generate more than 26 unique filenames for a given base. This happens in particular on Windows, and limits us to 26 scratch files open simultaneously. The patch works

[x32] PATCH: Only allow *movabs_[1|2] for TARGET_LP64

2011-03-12 Thread H.J. Lu
Hi, x32 is limited to 32bit address space. I checked in this patc to only allow *movabs_[1|2] for TARGET_LP64. H.J. --- commit 2ea3bfe6d0b96ad15e801d29fd28817138e93456 Author: H.J. Lu Date: Fri Mar 11 13:36:42 2011 -0800 Only allow *movabs_[1|2] for TARGET_LP64. diff --git a/gcc/ChangeL

[x32] PATCH: Add check_effective_target_ia32

2011-03-12 Thread H.J. Lu
Hi, We check ilp32 for ia32 tests in gcc testsuite. It won't work with x32. I checked in this patch to add ia32 target. H.J. -- commit 9383cb747c3de3c769fa3fb2aa9c148b344399b2 Author: H.J. Lu Date: Fri Mar 11 13:39:46 2011 -0800 Add check_effective_target_ia32. diff --git a/gcc/testsui

[x32] PATCH: PR target/48084: [x32] internal compiler error: in copy_to_mode_reg, at explow.c:630

2011-03-12 Thread H.J. Lu
Hi, I checked in this patch tp convert memory to Pmode if needed. H.J. Index: gcc/testsuite/gcc.target/i386/pr48084-3.c === --- gcc/testsuite/gcc.target/i386/pr48084-3.c (revision 0) +++ gcc/testsuite/gcc.target/i386/pr48084-3.c

[x32] PATCH: Don't generate byte 0x66 in TLS GD for TARGET_X32

2011-03-12 Thread H.J. Lu
Hi, For x32, pointers are 32bit. It uses movl %fs:0, %eax instead of movq %fs:0, %rax to load TCB pointer. I checked in this patch to avoid byte 0x66 in TLS GD for TARGET_X32. H.J. --- >From 8c92f0d4860fd2693af864d87804aaee843f2680 Mon Sep 17 00:00:00 2001 From: H.J. Lu Date: Sat, 12 Mar 2

PATCH: copy_addr_to_reg: Convert to Pmode if needed

2011-03-12 Thread H.J. Lu
Hi, copy_addr_to_reg doesn't check of mode is valid before copy it to Pmode. This patch converts to Pmode if needed. OK for 4.7? Thanks. H.J. -- diff --git a/gcc/ChangeLog.x32 b/gcc/ChangeLog.x32 index b85956c..3405300 100644 --- a/gcc/ChangeLog.x32 +++ b/gcc/ChangeLog.x32 @@ -1,5 +1,10 @@ 2

Re: [PATCH] Fix hpux10 string to real conversion defficiences

2011-03-12 Thread John David Anglin
> I have reviewed the patch and FX'scomments. So far so good. > > I may have missed something in the thread, but are you planning > modifications to the functions that call convert_real to allow the nan > or inf strings to be passed to convert_real? > > The read_real function is already handling

Re: [Patch, Fortran, Regression] PR 48059: ICE in in gfc_conv_component_ref: character function of extended type

2011-03-12 Thread Paul Richard Thomas
Janus, > The patch was regtested on x86_64-unknown-linux-gnu. Ok for trunk? > Yes, as discussed off-list, it looks OK to me. Get it committed asap! Thanks for the patch Paul > > > 2011-03-12  Janus Weil   > >        PR fortran/48059 >        * trans-expr.c (gfc_apply_interface_mapping_to_exp

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-12 Thread Kai Tietz
2011/3/9 Eli Zaretskii : >> From: Pedro Alves >> Date: Wed, 9 Mar 2011 12:58:38 + >> Cc: gdb-patc...@sourceware.org, >>  d...@redhat.com, >>  ktiet...@googlemail.com, >>  binut...@sourceware.org, >>  gcc-patches@gcc.gnu.org >> >> > > The one's left are: 1 in a linux-native only file (never car

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-12 Thread Kai Tietz
2011/3/8 DJ Delorie : > >> I think we don't need filename_dirchr, only filename_dirrchr. > > I see no harm in having both, for completeness, though.  One could > argue they should be in separate files, but they're trivial functions > on non-dos-fs systems. > > What bothers me about this patch is th

PATCH: Enable __float128 in gcc.target/i386/builtin-copysign.c for 32bit

2011-03-12 Thread H.J. Lu
Hi, __float128 has been supported on ia32 for a while. This patch removes __LP64__ check. OK for 4.7? Thanks. H.J. --- 2011-03-12 H.J. Lu * gcc.target/i386/builtin-copysign.c: Remove __LP64__ check. diff --git a/gcc/testsuite/gcc.target/i386/builtin-copysign.c b/gcc/testsuite/gcc

Re: [Patch, Fortran, Regression] PR 48059: ICE in in gfc_conv_component_ref: character function of extended type

2011-03-12 Thread Jerry DeLisle
On 03/12/2011 03:16 AM, Janus Weil wrote: Hi all, the attached patch fixes the PR in the subject line. The problem was the following: During the interface mapping for a procedure call we need to take special care of polymorphic arguments, since the type of the actual argument can differ from the

Re: [Patch, Fortran, Regression] PR 48059: ICE in in gfc_conv_component_ref: character function of extended type

2011-03-12 Thread Janus Weil
>> The patch was regtested on x86_64-unknown-linux-gnu. Ok for trunk? >> > > Yes, as discussed off-list, it looks OK to me.  Get it committed asap! Thanks. Committed as r170906. Cheers, Janus

Re: [fortran, patch] Fix memory leak in arith_power()

2011-03-12 Thread Tobias Burnus
FX wrote: While looking at the use of gfc_free() in the front-end when discussing its removal, I noticed one instance where gfc_free_expr() should be used instead. The patch that fixes it is: OK. Thanks for the patch! Tobias 2011-03-12 Francois-Xavier Coudert * arith.c (arith_powe

[patch] ping1 unbreak bootstrap on FreeBSD ppc

2011-03-12 Thread Andreas Tobler
All, I'd like to commit the below patch to gcc trunk and gcc-4.5. I have an ok from DJE, but I still await a comment from Loren. This is now pending for more than a month. And I'd like to push this out. Am I allowed to commit this to 4.6, or do I have to wait for 4.7 and then backport to 4.6?

[PATCH] prune warn_compact_unwind warnings on darwin

2011-03-12 Thread Jack Howarth
Xcode 4.0's linker now defaults on... -warn_compact_unwind When producing a final linked image, the linker processes the __eh_frame section and produces an __unwind_info section. Most FDE entries in the __eh_frame can be represented by a 32-bit value in

Re: [PATCH] Fix hpux10 string to real conversion defficiences

2011-03-12 Thread Jerry DeLisle
On 03/12/2011 08:01 AM, John David Anglin wrote: I have reviewed the patch and FX'scomments. So far so good. I may have missed something in the thread, but are you planning modifications to the functions that call convert_real to allow the nan or inf strings to be passed to convert_real? The r

[patch, fortran] Fix PR 48066

2011-03-12 Thread Thomas Koenig
Hello world, the attached patch fixes PR 48066, a regression introduced way back when. It is pretty self-explanatory. Regression-tested. OK for trunk? Also OK for a 4.5 backport? Thomas 2011-03-12 Thomas Koenig PR libfortran/40866 * m4/ifunction.m4: If return

Re: [libgfortran, patch] More than 26 temporary files with weak mktemp()

2011-03-12 Thread Jerry DeLisle
On 03/12/2011 07:21 AM, FX wrote: The attached patch fixes half of PR 47439. On platform with weak or historical implementations of mktemp(), this function cannot generate more than 26 unique filenames for a given base. This happens in particular on Windows, and limits us to 26 scratch files o

Re: [patch, fortran] Fix PR 48066

2011-03-12 Thread Jerry DeLisle
On 03/12/2011 02:09 PM, Thomas Koenig wrote: Hello world, the attached patch fixes PR 48066, a regression introduced way back when. It is pretty self-explanatory. Regression-tested. OK for trunk? OK and thanks for patch! Jerry

Re: [patch, fortran] Fix PR 48066

2011-03-12 Thread Thomas Koenig
Hi Jerry, On 03/12/2011 02:09 PM, Thomas Koenig wrote: Hello world, the attached patch fixes PR 48066, a regression introduced way back when. It is pretty self-explanatory. Regression-tested. OK for trunk? OK and thanks for patch! Übertrage Daten .

[x32] PATCH: Update gcc.target/i386 for x32

2011-03-12 Thread H.J. Lu
Many tests gcc.target/i386 use ilp32 to check ia32 and use lp64 to check hardware long long support. I checked in this to fix it. H.J. --- 2011-03-12 H.J. Lu * gcc.target/i386/2609-1.c: Require ia32 instead of ilp32. * gcc.target/i386/2720-1.c: Likewise. * gcc

Re: [patch, fortran] Fix PR 48066

2011-03-12 Thread Mikael Morin
On Saturday 12 March 2011 23:40:32 Thomas Koenig wrote: > Hi Jerry, > > > On 03/12/2011 02:09 PM, Thomas Koenig wrote: > >> Hello world, > >> > >> the attached patch fixes PR 48066, a regression introduced way back > >> when. It is > >> pretty self-explanatory. Regression-tested. > >> > >> OK fo

Re: [patch, fortran] Fix PR 48066

2011-03-12 Thread Thomas Koenig
Am 13.03.2011 00:04, schrieb Mikael Morin: On Saturday 12 March 2011 23:40:32 Thomas Koenig wrote: There was a typo in the PR number (both in the testcases and in the changelogs) Corrected. Thanks! Thomas

Re: [PATCH] Fix hpux10 string to real conversion defficiences

2011-03-12 Thread Jerry DeLisle
On 03/12/2011 02:04 PM, Jerry DeLisle wrote: On 03/12/2011 08:01 AM, John David Anglin wrote: I have reviewed the patch and FX'scomments. So far so good. I may have missed something in the thread, but are you planning modifications to the functions that call convert_real to allow the nan or inf

Re: [patch, fortran] Fix PR 48066

2011-03-12 Thread Jerry DeLisle
On 03/12/2011 03:04 PM, Mikael Morin wrote: On Saturday 12 March 2011 23:40:32 Thomas Koenig wrote: Hi Jerry, On 03/12/2011 02:09 PM, Thomas Koenig wrote: Hello world, the attached patch fixes PR 48066, a regression introduced way back when. It is pretty self-explanatory. Regression-tested.

Re: [x32] PATCH: Update gcc.target/i386 for x32

2011-03-12 Thread H.J. Lu
On Sat, Mar 12, 2011 at 02:44:26PM -0800, H.J. Lu wrote: > Many tests gcc.target/i386 use ilp32 to check ia32 and use lp64 to > check hardware long long support. I checked in this to fix it. > > Another patch. H.J. diff --git a/gcc/testsuite/ChangeLog.x32 b/gcc/testsuite/ChangeLog.x32 in

Re: [PATCH] Fix hpux10 string to real conversion defficiences

2011-03-12 Thread John David Anglin
> On 03/12/2011 02:04 PM, Jerry DeLisle wrote: > > On 03/12/2011 08:01 AM, John David Anglin wrote: > >>> I have reviewed the patch and FX'scomments. So far so good. > >>> > >>> I may have missed something in the thread, but are you planning > >>> modifications to the functions that call convert_re

Re: [PATCH RFA]: clean up -fdiagnostics-show-option and -Werror= docs slightly

2011-03-12 Thread Gabriel Dos Reis
OK.

Re: [PATCH, rs6000] Fix PR48053, ICEs in SPEC benchmarks

2011-03-12 Thread David Edelsohn
On Fri, Mar 11, 2011 at 1:34 PM, Peter Bergner wrote: > This patch fixes the two related bugs in PR48053.  The problem here deals > with loading constants into VSX registers.  The first bug occurs when we > try and load up a full constant into the VSX register.  We end up calling > easy_vector_con

Re: [PATCH, rs6000] Fix PR48053, ICEs in SPEC benchmarks

2011-03-12 Thread Peter Bergner
On Sat, 2011-03-12 at 22:21 -0500, David Edelsohn wrote: > > gcc/ > >PR target/48053 > >* config/rs6000/predicates.md (easy_vector_constant_add_self, > >easy_vector_constant_msb): Do not handle V2DImode and V2DFmode. > >* config/rs6000/rs6000.c (const_vector_elt_as_i