Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jakub Jelinek
On Thu, Mar 10, 2011 at 06:02:50PM -0500, Jason Merrill wrote: > On 03/10/2011 11:14 AM, Dodji Seketeli wrote: > >+ /* If we are initializing a sub-object of > >+ CURRENT_OBJECT_TYPE [for which a primary base class > >+ sub-object has already been initialized] then we must NOT

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-03-11 Thread Mike Stump
The objective c bits are ok.

Re: [4.7 PATCH 00/18] slim down a number of tree nodes

2011-03-11 Thread Mike Stump
On Mar 10, 2011, at 8:23 PM, Nathan Froyd wrote: > This patch series does something similar to what I am curious what the speed differences are.

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jakub Jelinek
On Fri, Mar 11, 2011 at 09:01:40AM +0100, Jakub Jelinek wrote: > Do we need to redo parts of class.c anyway? From what I understand, the > problematic vtbl pointers are at the end of the base types and DECL_SIZE > is set to the CLASSTYPE_AS_BASE type size, thus those pointers ought to > be at or b

[PING] 3 pending patches

2011-03-11 Thread Andreas Krebbel
This one is important to me for 4.6.0. This problem causes wrong code to be generated for decimal floating point programs: [PATCH] Fix PR46399 - missing mode promotion for libcall args - updated http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00141.html To my understandig this is a testcase bug. P

Re: [patch, score] Remove score3 from score backend, delete unusual insn generate

2011-03-11 Thread Paolo Bonzini
On 03/11/2011 07:16 AM, Liqin Chen wrote: @@ -181,10 +181,8 @@ score_output_mi_thunk (FILE *file, tree HOST_WIDE_INT delta, HOST_WIDE_INT vcall_offset, tree function) { - if (TARGET_SCORE5 || TARGET_SCORE5U || TARGET_SCORE7 || TARGET_SCORE7D) +

Re: [C++0x patch] constexpr in attribute argument

2011-03-11 Thread Rodrigo Rivas
On Fri, Mar 11, 2011 at 6:51 AM, Jason Merrill wrote: > How about just calling maybe_constant_value call after the > fold_non_dependent_expr call in cp_parser_parenthesized_expression_list? Well, I first tried something like this, but the key problem is the *non_dependent* part, so it does nothin

[PATCH, 4.6] Do not create new cgraph noes in the verifier

2011-03-11 Thread Martin Jambor
Hi, while working on removing lazy cgraph node creation I have noticed that we might do that even in the call graph verifier which certainly looks undesirable. Richi pre-approved removing it on IRC but I am not sure whether that was for 4.6. On the other hand I guess the change is rather obvious

[PATCH, 4.7] Have all inlining destinations "analyzed"

2011-03-11 Thread Martin Jambor
Hi, after I simply moved id->dst_node->analyzed check from expand_call_inline to optimize_inline_calls I tried asserting it there instead. When running testsuite I found out this works for everything but mudflap which adds new nodes late with cgraph_add_new_function which runs the inliner on node

Re: [PATCH, 4.6] Do not create new cgraph noes in the verifier

2011-03-11 Thread Richard Guenther
On Fri, 11 Mar 2011, Martin Jambor wrote: > Hi, > > while working on removing lazy cgraph node creation I have noticed > that we might do that even in the call graph verifier which certainly > looks undesirable. Richi pre-approved removing it on IRC but I am not > sure whether that was for 4.6.

[PATCH] Fixup testcase for PR47278

2011-03-11 Thread Richard Guenther
I forgot to check for visibility support. I've also copied the testcases to trunk. Richard. 2011-03-11 Richard Guenther PR tree-optimization/47278 * gcc.dg/torture/pr47278-1.c: Require visibility support. * gcc.dg/torture/pr47278-2.c: Likewise. Index: gcc/testsuite/

Re: [PATCH][C] Fix PR47939

2011-03-11 Thread Richard Guenther
On Thu, 10 Mar 2011, Joseph S. Myers wrote: > On Wed, 2 Mar 2011, Richard Guenther wrote: > > > 2011-03-02 Richard Guenther > > > > PR c/47939 > > * c-decl.c (grokdeclarator): Drop to the main variant only > > for array types. Drop flag_gen_aux_info check. > > I can't convince m

Re: [patch, score] Remove score3 from score backend, delete unusual insn generate

2011-03-11 Thread Liqin Chen
2011/3/11 Paolo Bonzini : > On 03/11/2011 07:16 AM, Liqin Chen wrote: > > Can you please in a follow-up merge score.c and score7.c, so that you can > remove these forwarding functions? > OK, We will do it. Thanks, --liqin

Re: [PATCH 14/18] move TS_STATEMENT_LIST to be a substructure of TS_TYPED

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 01:01:37AM -0500, Jason Merrill wrote: > On 03/10/2011 11:23 PM, Nathan Froyd wrote: >> The new checks in add_stmt are >> required to make sure that cur_stmt_list can always point at something >> when calling append_to_statement_list_force. > > Why haven't we already pushed

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Richard Guenther
On Thu, 10 Mar 2011, Rainer Orth wrote: > Richard Guenther writes: > > >> > Can we to fix 46944 change the dejagnu require-linker-plugin > >> > to check if a linker plugin is used by default and not add > >> > -fuse-linker-plugin? > >> > >> That might be involved since it requires parsing gcc -

Re: 4.5 backport request...

2011-03-11 Thread Richard Guenther
On Thu, Mar 10, 2011 at 10:07 PM, DJ Delorie wrote: > >> This doesn't look like a regression fix.  The changelog doesn't tell >> if it is mere replacing macros by hooks, so please also attach the >> patch. > > The original patch is here: > > http://gcc.gnu.org/ml/gcc/2010-10/msg00076.html > > It w

Re: Problem with procedure pointers

2011-03-11 Thread Tobias Burnus
On 03/10/2011 08:55 PM, Janus Weil wrote: Ok, since you guys seem to agree on that, here is the patch without module version bumping, but this time complete with test case and ChangeLog. Ok for trunk? OK. Thanks for the patch. Tobias 2011-03-10 Janus Weil PR fortran/47768

Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler

2011-03-11 Thread Joseph S. Myers
On Thu, 10 Mar 2011, Nathan Froyd wrote: > This patch does lose location information on CASE_LABEL_EXPRs from the C > family of front-ends; it did not seem worth it to have a number of > places pass input_location when said information isn't even used. I'm > happy to add the location_t argument b

Re: [PATCH 01/18] add typed_tree structure

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > The first step in removing TREE_CHAIN (and even TREE_TYPE) from a select > few nodes is to create separate substructures for trees-with-type and > trees-with-chain.  Since trees-with-type but no chain are expected to be > more common that vice

Re: [PATCH 05/18] remove TREE_CHAIN from CONSTRUCTOR nodes

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > A straightforward conversion. Ok for 4.7. Thanks, Richard. > -Nathan > > gcc/ >        * tree.h (struct tree_constructor): Include typed_tree instead of >        tree_common. >        * tree.c (initialize_tree_contains_struct): Mark TS_CONS

Re: [PATCH 03/18] remove TREE_CHAIN from *_CST nodes

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > *_CST nodes don't need TREE_CHAIN.  Make them include typed_tree instead, > mark them as such in initialize_tree_contains_struct, and don't print out > their TREE_CHAIN. Ok for 4.7 if it bootstraps and tests for all languages. Richard. > -N

Re: [PATCH 04/18] remove TREE_CHAIN from SSA_NAME nodes

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > This conversion is straightforward.  The tricky part is converting > FREE_SSANAMES into a VEC to eliminate the only use of TREE_CHAIN on > SSA_NAMEs. Ok for 4.7. Thanks, Richard. > -Nathan > > gcc/ >        * tree-flow.h (struct gimple_df):

Re: [PATCH 06/18] define CASE_CHAIN accessor for CASE_LABEL_EXPR

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > This patch begins a subseries of patches aimed at removing TREE_CHAIN > from expression trees.  tree-cfg.c uses TREE_CHAIN for some analysis > steps on CASE_LABEL_EXPRs.  I looked at this for a while, thinking it'd > be easy to use VECs instea

Re: [PATCH][C] Fix PR47939

2011-03-11 Thread Joseph S. Myers
On Fri, 11 Mar 2011, Richard Guenther wrote: > Indeed. I tried to let the array case alone (because it's so > complicated) but failed to do so. Appearantly > > if (declarator->kind == cdk_array && TYPE_QUALS (element_type)) > type = TYPE_MAIN_VARIANT (type); > > leaves it alone (and does

Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 2:01 PM, Joseph S. Myers wrote: > On Thu, 10 Mar 2011, Nathan Froyd wrote: > >> This patch does lose location information on CASE_LABEL_EXPRs from the C >> family of front-ends; it did not seem worth it to have a number of >> places pass input_location when said information

Re: [PATCH 16/18] make TS_IDENTIFIER be a substructure of TS_BASE

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > Now that we've done the requisite surgery on the C++ FE, we can > eliminate TREE_CHAIN and TREE_TYPE from IDENTIFIER_NODEs.  Doing so > turns up a couple different places that need to be tweaked. > > The bit I'm not quite sure about is free_la

Re: [PATCH 17/18] introduce block_chainon and use BLOCK_CHAIN more

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > BLOCKs have a TREE_CHAIN and a TREE_TYPE; TREE_TYPE is useless for > blocks, but we can't remove TREE_TYPE without also removing TREE_CHAIN. > This patch lays the groundwork to do just that.  It changes places that > use chainon on BLOCKs to u

Re: [PATCH 17/18] introduce block_chainon and use BLOCK_CHAIN more

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 02:15:20PM +0100, Richard Guenther wrote: > On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd > wrote: > > BLOCKs have a TREE_CHAIN and a TREE_TYPE; TREE_TYPE is useless for > > blocks, but we can't remove TREE_TYPE without also removing TREE_CHAIN. > > This patch lays the gro

Re: [PATCH 12/18] make CASE_LABEL_EXPR not abuse TREE_CHAIN

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > Move CASE_CHAIN into a local operand for CASE_LABEL_EXPR.  Nothing to > see here. I wonder if there isn't a better way to do this ... like always requiring operand 2 of SWITCH_EXPRs. Richard. > -Nathan > > gcc/ >        * tree.def (CASE_LAB

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > Now that we have a structure where not every node might include > TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said > accessors that the argument is properly typed.  This requires a number > of changes: > > - It's not enough

bf54x support

2011-03-11 Thread Henderson, Stuart
The attached patch adds support for silicon revision 0.4 of the bf54x family. 2011-02-17 Mike Frysinger * gcc.target/bfin/mcpu-bf542.c: Check SILICON_REVISION is 0x0004. * gcc.target/bfin/mcpu-bf544.c, gcc.target/bfin/mcpu-bf547.c, gcc.target/bfin/mcpu-bf548.c, gcc.target/bfin/mcpu-b

Re: [4.7 PATCH 00/18] slim down a number of tree nodes

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > This patch series does something similar to what: > > http://gcc.gnu.org/ml/gcc-patches/2010-11/msg02491.html > > did, only it does it in a cleaner way and it addresses the problem more > generally.  It introduces a separate substructure (base

Re: [PATCH, 4.7] Have all inlining destinations "analyzed"

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 10:58 AM, Martin Jambor wrote: > Hi, > > after I simply moved id->dst_node->analyzed check from > expand_call_inline to optimize_inline_calls I tried asserting it there > instead.  When running testsuite I found out this works for everything > but mudflap which adds new nod

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

2011-03-11 Thread Jason Merrill
On 03/10/2011 11:23 PM, Nathan Froyd wrote: I'm not overly fond of the conditionals (especially in error_operand_p) but I don't think it's reasonable to make IDENTIFIER_NODE bigger and penalize the other FEs just because the C++ FE is playing games with TREE_TYPE. The C++ FE expects that we can

Re: [4.7 PATCH 00/18] slim down a number of tree nodes

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 02:25:38PM +0100, Richard Guenther wrote: > On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd > wrote: > > This patch series does something similar to what: > > > > http://gcc.gnu.org/ml/gcc-patches/2010-11/msg02491.html > > > > did, only it does it in a cleaner way and it add

[Patch][AVR]: Support tail calls

2011-03-11 Thread Georg-Johann Lay
This is a patch to test/review/comment on. It adds tail call optimization to avr backend. The implementation uses struct machine_function to pass information around, i.e. from avr_function_arg_advance to avr_function_ok_for_sibcall. Tail call support is more general than avr-ld's replacement of c

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 08:40:24AM -0500, Jason Merrill wrote: > On 03/10/2011 11:23 PM, Nathan Froyd wrote: >> I'm not overly fond of the conditionals (especially in error_operand_p) >> but I don't think it's reasonable to make IDENTIFIER_NODE bigger and >> penalize the other FEs just because the

[patch][4.7] Enhance XOR handling in simplify-rtx.c

2011-03-11 Thread Chung-Lin Tang
Hi, this patch adds a bit more sophistication to the handled xor RTX cases in foo(). This may look a bit ad hoc, but I am seeing it useful for some cases where we combine zero_extend with (not (shift ...)). The supplied ARM testcase demonstrates when 3-insn combining comes up with: (set (reg:SI 1

Re: Problem with procedure pointers

2011-03-11 Thread Janus Weil
>> Ok, since you guys seem to agree on that, here is the patch without module >> version bumping, but this time complete with test case and ChangeLog. >> Ok for trunk? > > OK. Thanks for the patch. Thanks. Committed as r170871. Cheers, Janus >> 2011-03-10  Janus Weil >> >>        PR fortran/47

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 06:04:45AM -0800, Nathan Froyd wrote: > On Fri, Mar 11, 2011 at 08:40:24AM -0500, Jason Merrill wrote: > > On 03/10/2011 11:23 PM, Nathan Froyd wrote: > > The C++ FE expects that we can check the TREE_TYPE of anything that > > appears as an expression, and uses IDENTIFIER_

Re: [PATCH, 4.6] Do not create new cgraph noes in the verifier

2011-03-11 Thread Jan Hubicka
> Hi, > > while working on removing lazy cgraph node creation I have noticed > that we might do that even in the call graph verifier which certainly > looks undesirable. Richi pre-approved removing it on IRC but I am not > sure whether that was for 4.6. On the other hand I guess the change > is

RE: [Patch][AVR]: Support tail calls

2011-03-11 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [mailto:a...@gjlay.de] > Sent: Friday, March 11, 2011 6:44 AM > To: gcc-patches@gcc.gnu.org > Cc: Denis Chertykov; Anatoly Sokolov; Weddington, Eric; Boyapati, Anitha > Subject: [Patch][AVR]: Support tail calls > > This is a patch to test/rev

Re: [PATCH, 4.7] Have all inlining destinations "analyzed"

2011-03-11 Thread Jan Hubicka
> Index: src/gcc/cgraph.c > === > --- src.orig/gcc/cgraph.c > +++ src/gcc/cgraph.c > @@ -2495,11 +2495,11 @@ cgraph_add_new_function (tree fndecl, bo >case CGRAPH_STATE_FINISHED: > /* At the very end of compilation we hav

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Rainer Orth
Richard Guenther writes: >> Only with -save-temps, otherwise it's some random file in /var/tmp. But >> even so the file is removed immediately. > > The following seems to work for me > > Index: gcc/testsuite/lib/target-supports.exp > ==

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

2011-03-11 Thread Joseph S. Myers
On Fri, 11 Mar 2011, Jason Merrill wrote: > On 03/10/2011 11:23 PM, Nathan Froyd wrote: > > I'm not overly fond of the conditionals (especially in error_operand_p) > > but I don't think it's reasonable to make IDENTIFIER_NODE bigger and > > penalize the other FEs just because the C++ FE is playing

Re: RFA (layout): PATCH for c++/48029 (ICE-on-valid with templates and arrays)

2011-03-11 Thread Jason Merrill
On 03/10/2011 09:56 AM, Jason Merrill wrote: While looking at the history, it occurred to me that COMPLETE_OR_UNBOUND_ARRAY_TYPE_P is a better test than TYPE_SIZE in the type_hash_eq change, so I'm going to make that tweak to the patch OK, apparently this was a bad idea; it caused 48069. So I

[Patch ARM] Fix PR47688

2011-03-11 Thread Ramana Radhakrishnan
Hi, This patch fixes PR47688 which is a regression from gcc 4.4 and which ends up fixing https://bugs.launchpad.net/gcc-linaro/+bug/730440. The change is essentially in the punctuation character to only print out the lower 16 bits of the constant. I'll commit this into trunk and backport thi

[committed] Fix cgraph ICE with aliases (PR middle-end/48044)

2011-03-11 Thread Jakub Jelinek
Hi! I've committed this fix, where cgraph_remove_unreachable_nodes was clearing vnode->needed for nodes marked as force_output because something was aliasing them. For -O1 the varpool nodes were removed completely (also undesirable), but for -O0 they were kept around and ICEd because needed wasn'

Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler

2011-03-11 Thread Tom Tromey
> "Nathan" == Nathan Froyd writes: Nathan> gcc/java/ Nathan> * expr.c (expand_java_switch): Call build_case_label. Nathan> (expand_java_add_case): Likewise. The java parts are ok. FWIW, I tend to think that if a core change like this one is accepted, then updates to the fron

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jason Merrill
On 03/11/2011 03:01 AM, Jakub Jelinek wrote: Do we need to redo parts of class.c anyway? From what I understand, the problematic vtbl pointers are at the end of the base types and DECL_SIZE is set to the CLASSTYPE_AS_BASE type size, thus those pointers ought to be at or beyond the containing fie

Re: [Patch][AVR]: Support tail calls

2011-03-11 Thread Georg-Johann Lay
Weddington, Eric schrieb: > >> -Original Message- >> From: Georg-Johann Lay [mailto:a...@gjlay.de] >> Sent: Friday, March 11, 2011 6:44 AM >> To: gcc-patches@gcc.gnu.org >> Cc: Denis Chertykov; Anatoly Sokolov; Weddington, Eric; Boyapati, Anitha >> Subject: [Patch][AVR]: Support tail calls

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

2011-03-11 Thread Jason Merrill
On 03/11/2011 09:19 AM, Nathan Froyd wrote: On Fri, Mar 11, 2011 at 06:04:45AM -0800, Nathan Froyd wrote: On Fri, Mar 11, 2011 at 08:40:24AM -0500, Jason Merrill wrote: On 03/10/2011 11:23 PM, Nathan Froyd wrote: The C++ FE expects that we can check the TREE_TYPE of anything that appears as an

testcase for PR c/36299

2011-03-11 Thread Vincent Lefevre
As asked in PR c/36299[*], here's a testcase for this PR. It checks the absence of warning for some valid C code, to make sure the warning no longer reappears in future GCC versions. [*] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36299#c10 -- Vincent Lefèvre - Web: 100

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jakub Jelinek
On Fri, Mar 11, 2011 at 09:56:59AM -0500, Jason Merrill wrote: > On 03/11/2011 03:01 AM, Jakub Jelinek wrote: > >Do we need to redo parts of class.c anyway? From what I understand, the > >problematic vtbl pointers are at the end of the base types and DECL_SIZE > >is set to the CLASSTYPE_AS_BASE ty

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Richard Guenther
On Fri, 11 Mar 2011, Rainer Orth wrote: > Richard Guenther writes: > > >> Only with -save-temps, otherwise it's some random file in /var/tmp. But > >> even so the file is removed immediately. > > > > The following seems to work for me > > > > Index: gcc/testsuite/lib/target-supports.exp > > ===

[PATCH] Fix PR48067

2011-03-11 Thread Richard Guenther
We shouldn't try to make use of the multiplication result twice in FMA_EXPR building. The following ensures that if the uses go through a negate. Bootstrap and regtest processing on x86_64-unknown-linux-gnu. Richard. 2011-03-11 Richard Guenther PR tree-optimization/48067 *

Re: [PATCH 17/18] introduce block_chainon and use BLOCK_CHAIN more

2011-03-11 Thread Tom Tromey
> "Nathan" == Nathan Froyd writes: Nathan> gcc/java/ Nathan> * decl.c (poplevel): Use BLOCK_CHAIN and block_chainon. This is ok. Tom

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Dodji Seketeli
Jason Merrill writes: > If we're currently initializing a subobject, then we don't want to > initialize any of our virtual base fields unless they are primary to > the current type. Indeed. I think I understand better now. > I'm also rather nervous about using is_*_base_of tests given that a >

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Rainer Orth
Richard Guenther writes: >> Still doesn't work for me if compiling and linking manually with GNU ld >> 2.21 on Solaris 11/x86: no .res file is being created, although >> liblto_plugin.so is used. > > "Work" as in, it detects if -fuse-linker-plugin is enabled by default. > Which it isn't for you?

Re: [PATCH 01/18] add typed_tree structure

2011-03-11 Thread Michael Matz
Hi, On Thu, 10 Mar 2011, Nathan Froyd wrote: > * tree.h (struct typed_tree): New. IMO this should be called tree_typed, like the other structs in tree.h . Ciao, Michael.

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-03-11 Thread Tom Tromey
> "Nathan" == Nathan Froyd writes: Nathan> gcc/java/ Nathan> * java-tree.h (union lang_tree_node): Check for TS_COMMON before Nathan> calling TREE_CHAIN. This is ok. Tom

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Richard Guenther
On Fri, 11 Mar 2011, Rainer Orth wrote: > Richard Guenther writes: > > >> Still doesn't work for me if compiling and linking manually with GNU ld > >> 2.21 on Solaris 11/x86: no .res file is being created, although > >> liblto_plugin.so is used. > > > > "Work" as in, it detects if -fuse-linker-p

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jason Merrill
On 03/11/2011 10:08 AM, Jakub Jelinek wrote: It worked, here is what I've bootstrapped/regtested on x86_64-linux and i686-linux. Is that ok then? OK. Jason

Re: [wwwdocs] Nits in gcc-4.6/changes.html

2011-03-11 Thread Rainer Orth
Hi Gerald, > On Mon, 31 Jan 2011, Rainer Orth wrote: >> I've read all of the GCC 4.6 changes.html over the weekend and found a >> couple of issues (mostly nits). The ones I consider obvious are >> included in the patch below (though I'm not a native speeker and may >> simply be mistaken), but the

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Rainer Orth
Richard Guenther writes: >> I'm using gld 2.21, and -flto automatically uses the linker plugin, as >> seen with -v. Despite that, -plugin-opt=-fresolution=ldl.res is passed >> to collect2/ld, but no ldl.res file is created. In truss, I see a stat >> of that file, but nothing more. > > Interesti

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jason Merrill
On 03/11/2011 10:15 AM, Dodji Seketeli wrote: I have updated is_virtual_base_of to make it test if the current field represents a virtual base. Is there a simpler way to detect that? Yeah, let's go with Jakub's patch. Jason

[PATCH] Fix PR48073

2011-03-11 Thread Richard Guenther
48073 * tree.c (find_decls_types_r): Do not walk types only reachable from IDENTIFIER_NODEs. * g++.dg/lto/20110311-1_0.C: New testcase. Index: gcc/tree.c === --- gcc/tree.c (revision 170868) +++ gcc/tree.c (working

Re: [C++0x patch] constexpr in attribute argument

2011-03-11 Thread Jason Merrill
On 03/11/2011 04:33 AM, Rodrigo Rivas wrote: On Fri, Mar 11, 2011 at 6:51 AM, Jason Merrill wrote: How about just calling maybe_constant_value call after the fold_non_dependent_expr call in cp_parser_parenthesized_expression_list? Well, I first tried something like this, but the key problem i

Re: [4.7 PATCH 00/18] slim down a number of tree nodes

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 12:18:15AM -0800, Mike Stump wrote: > On Mar 10, 2011, at 8:23 PM, Nathan Froyd wrote: > > This patch series does something similar to what > > I am curious what the speed differences are. A non-rigorous, C-only, release-checking bootstrap (which showed me that I forgot t

[PATCH] Fix inliner defaults in invoke.texi

2011-03-11 Thread Richard Guenther
Committed. Richard. 2011-03-11 Richard Guenther * doc/invoke.texi (max-inline-insns-single): Adjust default value. Index: gcc/doc/invoke.texi === --- gcc/doc/invoke.texi (revision 170874) +++ gcc/doc/invoke.texi (workin

Re: [PATCH] Fix PR48073

2011-03-11 Thread Michael Matz
Hi, On Fri, 11 Mar 2011, Richard Guenther wrote: > This fixes PR48073 - we are not interested in types on IDENTIFIER_NODEs > for LTO and thus we don't need to walk types or decls that hang off such > types. free_lang_data should probably clear TREE_TYPE for IDENTIFIER_NODEs then. Ciao, Micha

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 10:03:43AM -0500, Jason Merrill wrote: > On 03/11/2011 09:19 AM, Nathan Froyd wrote: >>> I'm confused. Isn't this what the switching on IDENTIFIER_NODE in a >>> number of places is doing? (And any future places that g++/libstdc++ >>> didn't catch will be an ICE.) Or are y

Re: [C++0x patch] constexpr in attribute argument

2011-03-11 Thread Rodrigo Rivas
On Fri, Mar 11, 2011 at 4:58 PM, Jason Merrill wrote: > Sure, I guess calling it in one place is better.  But I think let's wait > until 4.6.1 for this patch. Oh, I didn't notice the only-regression-fixes status. No problem. -- Rodrigo.

[PATCH] PR c++/46824

2011-03-11 Thread Dodji Seketeli
Hello, In my fix for PR c++/42260 I wanted to exclude conversion operators that return dependent types from the candidates functions during overload resolution in cases like: struct A { template operator T*(); }; int i = *A(); During the overload resolution to determin

C++ PATCH for c++/47808 (C++0x ICE with VLA in template)

2011-03-11 Thread Jason Merrill
The problem here was that we were tsubsting twice: first we did fold_non_dependent_expr in compute_array_index_type to try and get a constant, then because we didn't end up with a constant, we later tsubst it again. So if it didn't work out the first time, we should revert to the unfolded form

Re: [PATCH] PR c++/46824

2011-03-11 Thread Jason Merrill
OK. Jason

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

2011-03-11 Thread Jason Merrill
On 03/11/2011 11:23 AM, Nathan Froyd wrote: Hm. OK. Just as a light sketch of how this would all work, where do DEPENDENT_NAME_EXPRs get introduced into the AST? During parsing, or someplace else? During parsing, yes, wherever we look up a name and currently return the plain identifier rath

Re: 4.5 backport request...

2011-03-11 Thread DJ Delorie
> I don't think this is suitable for the branch. Any reason why you > can't work on the trunk? The vendor's release is 4.5 based, and 4.6 has some performance regressions with this chip. We'd like to sync up the FSF sources with the minor patches the vendor is using, so that their customers can

Re: [PATCH 16/18] make TS_IDENTIFIER be a substructure of TS_BASE

2011-03-11 Thread Nathan Froyd
On Fri, Mar 11, 2011 at 02:12:06PM +0100, Richard Guenther wrote: > On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd > wrote: > > Now that we've done the requisite surgery on the C++ FE, we can > > eliminate TREE_CHAIN and TREE_TYPE from IDENTIFIER_NODEs.  Doing so > > turns up a couple different pl

Re: [PATCH][ARM] Fix RVCT interoperation issue

2011-03-11 Thread Andrew Stubbs
On 09/03/11 16:12, Ramana Radhakrishnan wrote: On Fri, 2011-03-04 at 11:23 +, Andrew Stubbs wrote: The attached patch, submitted on behalf of Dan Jacobowitz, fixes an unwind bug when using RealView and libgcc. It's an old patch that has been in CodeSourcery and Linaro toolchains for sometim

RE: [Patch][AVR]: Support tail calls

2011-03-11 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [mailto:a...@gjlay.de] > Sent: Friday, March 11, 2011 7:59 AM > To: Weddington, Eric > Cc: gcc-patches@gcc.gnu.org; Denis Chertykov; Anatoly Sokolov; Boyapati, > Anitha; Joerg Wunsch > Subject: Re: [Patch][AVR]: Support tail calls > > "Does n

[PATCH, rs6000] Fix PR48053, ICEs in SPEC benchmarks

2011-03-11 Thread Peter Bergner
This patch fixes the two related bugs in PR48053. The problem here deals with loading constants into VSX registers. The first bug occurs when we try and load up a full constant into the VSX register. We end up calling easy_vector_constant_msb which is supported only for V4SI and V4SF modes. The

Re: [PATCH, rs6000] Fix PR48053, ICEs in SPEC benchmarks

2011-03-11 Thread Peter Bergner
On Fri, 2011-03-11 at 12:34 -0600, Peter Bergner wrote: > This patch fixes the two related bugs in PR48053. The problem here deals > with loading constants into VSX registers. The first bug occurs when we > try and load up a full constant into the VSX register. We end up calling > easy_vector_co

Re: fix for pr47837

2011-03-11 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 11:07, Xinliang David Li wrote: > Ok. > > Regarding this particular patch, I hope it can be checked in to make > the test clean. It is a simple enhancement to a wheel that is already > there. It also serves as a case that can be referenced

Re: fix for pr47837

2011-03-11 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 09:24, Xinliang David Li wrote: > On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: > On 03/09/11 02:45, Richard Guenther wrote: On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrote: > True. I've been repeatedly thinking of building

PATCH to attribute_takes_identifier_p for c++/46803

2011-03-11 Thread Jason Merrill
In 46803 we have an unknown attribute that apparently takes an identifier as its first argument; since my introduction of attribute_takes_identifier_p, we assume that most attributes do not take an identifier as their first argument. But it won't hurt to assume the contrary for unknown attribu

[PATCH] Fix PR47127: call cloog_state_malloc and cloog_state_free only once.

2011-03-11 Thread Sebastian Pop
Hi, we currently call cloog_state_malloc and cloog_state_free too many times. In CLooG-Parma, these functions contain the init and fini functions of PPL, and so calling these in the middle of graphite would finalize all the PPL data structures, leading to memory corruption. This patch fixes this

Re: PATCH to attribute_takes_identifier_p for c++/46803

2011-03-11 Thread Jason Merrill
On 03/11/2011 04:35 PM, Jason Merrill wrote: Tested x86_64-pc-linux-gnu, applied to trunk. Hmm, I thought bootstrap used -Werror, but I just noticed some build warnings from this change. Fixed thus. commit 9bf1c74e01512f43f764c9a4d437f9d999b74117 Author: jason Date: Fri Mar 11 22:38:58 201

C++ PATCH for c++/47144 (accepts-invalid with type definition in template argument)

2011-03-11 Thread Jason Merrill
G++ was oddly accepting this testcase even though it uses a name which is not defined anywhere. This turns out to be because when we see the struct B { } we commit to all tentative parses. We happened to be in the middle of testing whether A<...>::SomeNonSense is a constructor declarator, so

[x32] PR target/47446: [x32] .quad instead of .long is used for address

2011-03-11 Thread H.J. Lu
I checked in this patch to always allow the offsetted memory references for TARGET_X32. H.J. commit 8dba2cfc28716e09853233e19500e44ba2619cb6 Author: H.J. Lu Date: Fri Mar 11 13:34:17 2011 -0800 Always allow the offsetted memory references for TARGET_X32. diff --git a/gcc/ChangeLog.x

Re: fix for pr47837

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 8:50 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/09/11 09:24, Xinliang David Li wrote: >> On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: >> On 03/09/11 02:45, Richard Guenther wrote: > On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wrot

Re: [PATCH] Fix PR47127: call cloog_state_malloc and cloog_state_free only once.

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 10:38 PM, Sebastian Pop wrote: > Hi, > > we currently call cloog_state_malloc and cloog_state_free too many > times.  In CLooG-Parma, these functions contain the init and fini > functions of PPL, and so calling these in the middle of graphite would > finalize all the PPL da

Re: fix for pr47837

2011-03-11 Thread Xinliang David Li
On Fri, Mar 11, 2011 at 11:50 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/09/11 09:24, Xinliang David Li wrote: >> On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law wrote: >> On 03/09/11 02:45, Richard Guenther wrote: > On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law wro

C++ PATCH for c++/47125 (ICE with template elaborated-type-specifier)

2011-03-11 Thread Jason Merrill
A straightforward case of some errors that were not properly protected by checking complain. Tested x86_64-pc-linux-gnu, applied to trunk. commit 49d36af37792ed3f1359f80443bc2ef9a25270c1 Author: Jason Merrill Date: Fri Mar 11 21:32:40 2011 -0500 PR c++/47125 * pt.c (tsubst) [