Re: offload data version number

2015-08-24 Thread Jakub Jelinek
On Thu, Aug 06, 2015 at 09:52:43PM +0200, Nathan Sidwell wrote: > Ping? > > 1) updated version patch > https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00010.html > > 2) https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00204.html > An infrastructure piece from Thomas, who noticed liboffloadmic didn't

Re: offload data version number

2015-08-10 Thread Thomas Schwinge
db429b590f4eead1bfb82745fe27 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 7 Aug 2015 09:49:50 +0200 Subject: [PATCH] Offload data version number -MM-DD Nathan Sidwell gcc/ * config/nvptx/mkoffload.c (process): Replace GOMP_offload_{,un}register with GOMP_offload_{,un}re

Re: offload data version number

2015-08-06 Thread Nathan Sidwell
Ping? 1) updated version patch https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00010.html 2) https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00204.html An infrastructure piece from Thomas, who noticed liboffloadmic didn't have the include paths to #include gomp-constants.h. nathan On 08/02/15

Re: offload data version number

2015-08-04 Thread Nathan Sidwell
On 08/04/15 12:17, Thomas Schwinge wrote: Hi! Nathan's patch is waiting for trunk approval: Then, for convenience, I'm also again attaching Nathan's patch: trunk-version-4.patch. Nathan, for the trunk commit, I suggest you simply merge my patch into yours. Yes, I'll atomically commit them.

Re: offload data version number

2015-08-04 Thread Thomas Schwinge
Hi! Nathan's patch is waiting for trunk approval: On Sat, 1 Aug 2015 20:06:39 -0400, Nathan Sidwell wrote: > On 07/31/15 12:10, Jakub Jelinek wrote: > > > This will hopefully be just GOMP_4.1 instead in the end, but it can > > change when gomp-4_1-branch is merged to trunk, we don't guarantee >

Re: offload data version number

2015-08-03 Thread Nathan Sidwell
On 08/03/15 07:15, Thomas Schwinge wrote: Hi! On Sat, 1 Aug 2015 20:20:49 -0400, Nathan Sidwell wrote: this is the gomp4 committed version. --- liboffloadmic/plugin/libgomp-plugin-intelmic.cpp(revision 226462) +++ liboffloadmic/plugin/libgomp-plugin-intelmic.cpp(working copy) @@ -32

Re: offload data version number

2015-08-03 Thread Thomas Schwinge
Hi! On Sat, 1 Aug 2015 20:20:49 -0400, Nathan Sidwell wrote: > this is the gomp4 committed version. > --- liboffloadmic/plugin/libgomp-plugin-intelmic.cpp (revision 226462) > +++ liboffloadmic/plugin/libgomp-plugin-intelmic.cpp (working copy) > @@ -327,12 +327,26 @@ offload_image (const void *

Re: offload data version number

2015-08-01 Thread Nathan Sidwell
On 08/01/15 20:06, Nathan Sidwell wrote: ok? I'll commit a version of this to gomp4 branch shortly. this is the gomp4 committed version. nathan 2015-08-01 Nathan Sidwell include/ * gomp-constants.h (GOMP_VERSION_INTEL_MIC): New. libgomp/ * plugin/plugin-nvptx.c (GOMP_OFFLOAD_load_i

Re: offload data version number

2015-08-01 Thread Nathan Sidwell
On 07/31/15 12:10, Jakub Jelinek wrote: This will hopefully be just GOMP_4.1 instead in the end, but it can change when gomp-4_1-branch is merged to trunk, we don't guarantee ABI stability at this point. Sure. I'd prefer version to go after devicep argument rather than before. Fixed. And

Re: offload data version number

2015-07-31 Thread Jakub Jelinek
> Index: libgomp/libgomp.map > === > --- libgomp/libgomp.map (revision 226039) > +++ libgomp/libgomp.map (working copy) > @@ -234,6 +234,12 @@ GOMP_4.0.1 { > GOMP_offload_unregister; > } GOMP_4.0; > > +GOMP_4.0.2 {

Re: offload data version number

2015-07-31 Thread Nathan Sidwell
On 07/31/15 08:16, Nathan Sidwell wrote: On 07/24/15 15:26, Nathan Sidwell wrote: Jakub, this version makes the following changes to the earlier version. *) Renames things to FOO_ver, rather than FOO_2 *) No attempt to deal with cross-version plugins and libgomp. *) Adds GOMP_OFFLOAD_version

Re: offload data version number

2015-07-31 Thread Nathan Sidwell
On 07/24/15 15:26, Nathan Sidwell wrote: Jakub, this version makes the following changes to the earlier version. *) Renames things to FOO_ver, rather than FOO_2 *) No attempt to deal with cross-version plugins and libgomp. *) Adds GOMP_OFFLOAD_version function to plugin. (I went with your appr

Re: offload data version number

2015-07-27 Thread Nathan Sidwell
On 07/24/15 09:32, Nathan Sidwell wrote: On 07/21/15 11:21, Nathan Sidwell wrote: I committed a version to gomp4 branch, but would still like to get this to trunk ASAP. I committed this update to the gomp4 branch to match the updated version currently under review for trunk. nathan 2015

Re: offload data version number

2015-07-24 Thread Nathan Sidwell
On 07/24/15 15:51, Ilya Verbin wrote: On Fri, Jul 24, 2015 at 15:26:38 -0400, Nathan Sidwell wrote: mber into mkoffload:process () like: 865 fprintf (out, "static const void *target_data[] = {\n"); 866 fprintf (out, " MAGIC, VERSION, ptx_code, (void*) %u, var_mappings, (void*) %u, " 867

Re: offload data version number

2015-07-24 Thread Ilya Verbin
On Fri, Jul 24, 2015 at 15:26:38 -0400, Nathan Sidwell wrote: > this version makes the following changes to the earlier version. > > *) Renames things to FOO_ver, rather than FOO_2 > > *) No attempt to deal with cross-version plugins and libgomp. > > *) Adds GOMP_OFFLOAD_version function to plug

Re: offload data version number

2015-07-24 Thread Nathan Sidwell
Jakub, this version makes the following changes to the earlier version. *) Renames things to FOO_ver, rather than FOO_2 *) No attempt to deal with cross-version plugins and libgomp. *) Adds GOMP_OFFLOAD_version function to plugin. (I went with your approach). Returns the GOMP_VERSION used to b

Re: offload data version number

2015-07-24 Thread Nathan Sidwell
On 07/24/15 12:30, Jakub Jelinek wrote: So there is no version anywhere? I remember in the design ideas the plan was that the data section containing the target info (that originally has been meant to be passed as GOMP_target parameter, but later on has been changed to the register/unregister a

Re: offload data version number

2015-07-24 Thread Ilya Verbin
On Fri, Jul 24, 2015 at 18:30:16 +0200, Jakub Jelinek wrote: > On Fri, Jul 24, 2015 at 09:32:04AM -0400, Nathan Sidwell wrote: > > On 07/21/15 11:21, Nathan Sidwell wrote: > > >On 07/21/15 09:25, Nathan Sidwell wrote: > > >>This trunk patch implements new register and unregister entry points to >

Re: offload data version number

2015-07-24 Thread Jakub Jelinek
On Fri, Jul 24, 2015 at 09:32:04AM -0400, Nathan Sidwell wrote: > On 07/21/15 11:21, Nathan Sidwell wrote: > >On 07/21/15 09:25, Nathan Sidwell wrote: > >>This trunk patch implements new register and unregister entry points to > >>allow > >>specifying data version information. (I'll shortly be po

Re: offload data version number

2015-07-24 Thread Nathan Sidwell
On 07/21/15 11:21, Nathan Sidwell wrote: On 07/21/15 09:25, Nathan Sidwell wrote: This trunk patch implements new register and unregister entry points to allow specifying data version information. (I'll shortly be posting patches changing the PTX offload data format.) We now have GOMP_offload_

Re: offload data version number

2015-07-21 Thread Nathan Sidwell
On 07/21/15 09:25, Nathan Sidwell wrote: This trunk patch implements new register and unregister entry points to allow specifying data version information. (I'll shortly be posting patches changing the PTX offload data format.) We now have GOMP_offload_{,un}register_2, which take an additional

offload data version number

2015-07-21 Thread Nathan Sidwell
This trunk patch implements new register and unregister entry points to allow specifying data version information. (I'll shortly be posting patches changing the PTX offload data format.) We now have GOMP_offload_{,un}register_2, which take an additional unsigned int version number. The versi