Re: libgo patch committed: set gp->m in getTraceback

2019-01-07 Thread Ian Lance Taylor
On Mon, Jan 7, 2019 at 12:12 PM Ian Lance Taylor wrote: > > This libgo patch by Cherry Zhang moves setting p->m from gtraceback to > getTraceback. Currently, when collecting a traceback for another > goroutine, getTraceback calls gogo(gp) switching to gp, which will > resume in mcall, which will

libgo patch committed: set gp->m in getTraceback

2019-01-07 Thread Ian Lance Taylor
This libgo patch by Cherry Zhang moves setting p->m from gtraceback to getTraceback. Currently, when collecting a traceback for another goroutine, getTraceback calls gogo(gp) switching to gp, which will resume in mcall, which will call gtraceback, which will set up gp->m. There is a gap between se