Re: libgo patch committed: Update to 1.11 release

2018-10-04 Thread Rainer Orth
Hi Ian, > Thanks for the note. This patch should fix the problem. Bootstrapped > and ran Go tests on x86_64-pc-linux-gnu, both normally and pretending > that the system had no memmem. Committed to mainline. I've now verified the patch on i386-pc-solaris2.10: bootstrap restored. Thanks.

Re: libgo patch committed: Update to 1.11 release

2018-10-03 Thread Ian Lance Taylor
On Mon, Oct 1, 2018 at 5:06 PM, Ian Lance Taylor wrote: > On Mon, Oct 1, 2018 at 4:56 PM, H.J. Lu wrote: >> >> Compared with my patch, there are some new failures: > > Thanks. We probably need a patch in gcc/testsuite/go.test/go-test.exp > to set goarch to amd64p32 when appropriate. This is tha

Re: libgo patch committed: Update to 1.11 release

2018-10-03 Thread H.J. Lu
On Mon, Oct 1, 2018 at 9:08 PM Ian Lance Taylor wrote: > > On Mon, Oct 1, 2018 at 6:57 PM, H.J. Lu wrote: > > On Mon, Oct 1, 2018 at 5:06 PM Ian Lance Taylor wrote: > >> > >> On Mon, Oct 1, 2018 at 4:56 PM, H.J. Lu wrote: > >> > > >> > Compared with my patch, there are some new failures: > >> >

Re: libgo patch committed: Update to 1.11 release

2018-10-02 Thread Ian Lance Taylor
On Fri, Sep 28, 2018 at 7:22 AM, Rainer Orth wrote: > >> I've committed a patch to update libgo to the 1.11 release. As usual >> for these updates, the patch is too large to attach to this e-mail >> message. I've attached some of the more relevant directories. This >> update required some minor

Re: libgo patch committed: Update to 1.11 release

2018-10-02 Thread Ian Lance Taylor
On Fri, Sep 28, 2018 at 12:05 AM, Uros Bizjak wrote: > On Wed, Sep 26, 2018 at 9:57 AM, Uros Bizjak wrote: >> I've committed a patch to update libgo to the 1.11 release. As usual >> for these updates, the patch is too large to attach to this e-mail >> message. I've attached some of the more rel

Re: libgo patch committed: Update to 1.11 release

2018-10-01 Thread Ian Lance Taylor
On Mon, Oct 1, 2018 at 6:57 PM, H.J. Lu wrote: > On Mon, Oct 1, 2018 at 5:06 PM Ian Lance Taylor wrote: >> >> On Mon, Oct 1, 2018 at 4:56 PM, H.J. Lu wrote: >> > >> > Compared with my patch, there are some new failures: >> >> Thanks. We probably need a patch in gcc/testsuite/go.test/go-test.exp

Re: libgo patch committed: Update to 1.11 release

2018-10-01 Thread H.J. Lu
On Mon, Oct 1, 2018 at 5:06 PM Ian Lance Taylor wrote: > > On Mon, Oct 1, 2018 at 4:56 PM, H.J. Lu wrote: > > > > Compared with my patch, there are some new failures: > > Thanks. We probably need a patch in gcc/testsuite/go.test/go-test.exp > to set goarch to amd64p32 when appropriate. > > Other

Re: libgo patch committed: Update to 1.11 release

2018-10-01 Thread Ian Lance Taylor
On Mon, Oct 1, 2018 at 4:56 PM, H.J. Lu wrote: > > Compared with my patch, there are some new failures: Thanks. We probably need a patch in gcc/testsuite/go.test/go-test.exp to set goarch to amd64p32 when appropriate. Other than that there seems to be some sort of signal handling problem. Hard

Re: libgo patch committed: Update to 1.11 release

2018-10-01 Thread H.J. Lu
On Mon, Oct 1, 2018 at 1:27 PM, H.J. Lu wrote: > On Mon, Oct 1, 2018 at 1:18 PM, Ian Lance Taylor wrote: >> On Wed, Sep 26, 2018 at 7:50 AM, H.J. Lu wrote: >>> On Mon, Sep 24, 2018 at 2:46 PM, Ian Lance Taylor wrote: I've committed a patch to update libgo to the 1.11 release. As usual >>>

Re: libgo patch committed: Update to 1.11 release

2018-10-01 Thread H.J. Lu
On Mon, Oct 1, 2018 at 1:18 PM, Ian Lance Taylor wrote: > On Wed, Sep 26, 2018 at 7:50 AM, H.J. Lu wrote: >> On Mon, Sep 24, 2018 at 2:46 PM, Ian Lance Taylor wrote: >>> I've committed a patch to update libgo to the 1.11 release. As usual >>> for these updates, the patch is too large to attach

Re: libgo patch committed: Update to 1.11 release

2018-10-01 Thread Ian Lance Taylor
On Wed, Sep 26, 2018 at 7:50 AM, H.J. Lu wrote: > On Mon, Sep 24, 2018 at 2:46 PM, Ian Lance Taylor wrote: >> I've committed a patch to update libgo to the 1.11 release. As usual >> for these updates, the patch is too large to attach to this e-mail >> message. I've attached some of the more rel

Re: libgo patch committed: Update to 1.11 release

2018-10-01 Thread Ian Lance Taylor
On Wed, Sep 26, 2018 at 3:54 AM, Andreas Schwab wrote: > All execution tests are now failing with "fatal error: impossible call > to aeshashbody". Thanks. Fixed by this patch, which adds AES hash code for arm64 using intrinsics. Bootstrapped and tested on x86_64-pc-linux-gnu and aarch4-unknown-

Re: libgo patch committed: Update to 1.11 release

2018-09-28 Thread Rainer Orth
Hi Ian, > I've committed a patch to update libgo to the 1.11 release. As usual > for these updates, the patch is too large to attach to this e-mail > message. I've attached some of the more relevant directories. This > update required some minor patches to the gotools directory and the Go > tes

Re: libgo patch committed: Update to 1.11 release

2018-09-28 Thread Uros Bizjak
On Wed, Sep 26, 2018 at 9:57 AM, Uros Bizjak wrote: > I've committed a patch to update libgo to the 1.11 release. As usual > for these updates, the patch is too large to attach to this e-mail > message. I've attached some of the more relevant directories. This > update required some minor patch

Re: libgo patch committed: Update to 1.11 release

2018-09-27 Thread Uros Bizjak
On Wed, Sep 26, 2018 at 5:18 PM, Ian Lance Taylor wrote: > On Wed, Sep 26, 2018 at 12:57 AM, Uros Bizjak wrote: >>> I've committed a patch to update libgo to the 1.11 release. As usual >>> for these updates, the patch is too large to attach to this e-mail >>> message. I've attached some of the

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Ian Lance Taylor
On Wed, Sep 26, 2018 at 12:57 AM, Uros Bizjak wrote: >> I've committed a patch to update libgo to the 1.11 release. As usual >> for these updates, the patch is too large to attach to this e-mail >> message. I've attached some of the more relevant directories. This >> update required some minor

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread H.J. Lu
On Wed, Sep 26, 2018 at 7:50 AM, H.J. Lu wrote: > On Mon, Sep 24, 2018 at 2:46 PM, Ian Lance Taylor wrote: >> I've committed a patch to update libgo to the 1.11 release. As usual >> for these updates, the patch is too large to attach to this e-mail >> message. I've attached some of the more rel

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread H.J. Lu
On Mon, Sep 24, 2018 at 2:46 PM, Ian Lance Taylor wrote: > I've committed a patch to update libgo to the 1.11 release. As usual > for these updates, the patch is too large to attach to this e-mail > message. I've attached some of the more relevant directories. This > update required some minor

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Ian Lance Taylor
On Wed, Sep 26, 2018 at 1:38 AM, Rainer Orth wrote: > >> On Sep 24 2018, Ian Lance Taylor wrote: >> >>> * Makefile.am (mostlyclean-local): Run chmod on check-go-dir to >>> make sure it is writable. >>> (check-go-tools): Likewise. >> >> $ make check-gotools >> make[1]: Entering directory `/usr/loc

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Ian Lance Taylor
On Wed, Sep 26, 2018 at 3:54 AM, Andreas Schwab wrote: > > All execution tests are now failing with "fatal error: impossible call > to aeshashbody". Which target? Ian

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Andreas Schwab
All execution tests are now failing with "fatal error: impossible call to aeshashbody". Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Rainer Orth
Hi Andreas, > On Sep 24 2018, Ian Lance Taylor wrote: > >> * Makefile.am (mostlyclean-local): Run chmod on check-go-dir to >> make sure it is writable. >> (check-go-tools): Likewise. > > $ make check-gotools > make[1]: Entering directory `/usr/local/gcc/gcc-20180926/Build/gotools' > chmod -R u+w

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Rainer Orth
Hi Ian, > On Tue, Sep 25, 2018 at 6:26 AM, Rainer Orth > wrote: >> >>> /vol/gcc/src/hg/trunk/local/libgo/go/runtime/traceback_gccgo.go:151:14: >>> error: reference to undefined name 'nanotime' >>> 151 | waitfor = (nanotime() - gp.waitsince) / 60e9 >>> | ^ >>> >>> and many ma

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Uros Bizjak
> I've committed a patch to update libgo to the 1.11 release. As usual > for these updates, the patch is too large to attach to this e-mail > message. I've attached some of the more relevant directories. This > update required some minor patches to the gotools directory and the Go > testsuite, a

Re: libgo patch committed: Update to 1.11 release

2018-09-26 Thread Andreas Schwab
On Sep 24 2018, Ian Lance Taylor wrote: > * Makefile.am (mostlyclean-local): Run chmod on check-go-dir to > make sure it is writable. > (check-go-tools): Likewise. $ make check-gotools make[1]: Entering directory `/usr/local/gcc/gcc-20180926/Build/gotools' chmod -R u+w check-go-dir chmod: cannot

Re: libgo patch committed: Update to 1.11 release

2018-09-25 Thread Ian Lance Taylor
On Tue, Sep 25, 2018 at 6:26 AM, Rainer Orth wrote: > >> /vol/gcc/src/hg/trunk/local/libgo/go/runtime/traceback_gccgo.go:151:14: >> error: reference to undefined name 'nanotime' >> 151 | waitfor = (nanotime() - gp.waitsince) / 60e9 >> | ^ >> >> and many many more instances.

Re: libgo patch committed: Update to 1.11 release

2018-09-25 Thread Ian Lance Taylor
On Tue, Sep 25, 2018 at 1:03 AM, Andreas Schwab wrote: > ../../../libgo/go/internal/cpu/cpu.go:21:16: error: reference to undefined > name ‘CacheLineSize’ > 21 | _[CacheLineSize]byte >|^ > ../../../libgo/go/internal/cpu/cpu.go:38:16: error: reference to undefined

Re: libgo patch committed: Update to 1.11 release

2018-09-25 Thread Rainer Orth
Hi Ian, > /vol/gcc/src/hg/trunk/local/libgo/go/runtime/traceback_gccgo.go:151:14: > error: reference to undefined name 'nanotime' > 151 | waitfor = (nanotime() - gp.waitsince) / 60e9 > | ^ > > and many many more instances. Again, I found an implementation in > upstream src

Re: libgo patch committed: Update to 1.11 release

2018-09-25 Thread Rainer Orth
Hi Ian, > I've committed a patch to update libgo to the 1.11 release. As usual > for these updates, the patch is too large to attach to this e-mail > message. I've attached some of the more relevant directories. This > update required some minor patches to the gotools directory and the Go > tes

Re: libgo patch committed: Update to 1.11 release

2018-09-25 Thread Andreas Schwab
../../../libgo/go/internal/cpu/cpu.go:21:16: error: reference to undefined name ‘CacheLineSize’ 21 | _[CacheLineSize]byte |^ ../../../libgo/go/internal/cpu/cpu.go:38:16: error: reference to undefined name ‘CacheLineSize’ 38 | _[CacheLineSize]byte |

Re: libgo patch committed: Update to 1.11 release

2018-09-25 Thread Andreas Schwab
It also breaks ia64. ../../../libgo/go/internal/bytealg/indexbyte_native.go:10:1: error: redefinition of 'IndexByte' 10 | func IndexByte(b []byte, c byte) int | ^ ../../../libgo/go/internal/bytealg/indexbyte_generic.go:12:1: note: previous definition of 'IndexByte' was here 12 | func IndexByt

Re: libgo patch committed: Update to 1.11 release

2018-09-24 Thread Andreas Schwab
This breaks aarch64/-mabi=ilp32. ../../../../libgo/go/internal/poll/splice_linux.go:165:45: error: reference to undefined identifier 'syscall.SYS_FCNTL' 165 | if _, _, errno := syscall.Syscall(syscall.SYS_FCNTL, uintptr(fds[0]), syscall.F_GETPIPE_SZ, 0); errno != 0 { |

libgo patch committed: Update to 1.11 release

2018-09-24 Thread Ian Lance Taylor
I've committed a patch to update libgo to the 1.11 release. As usual for these updates, the patch is too large to attach to this e-mail message. I've attached some of the more relevant directories. This update required some minor patches to the gotools directory and the Go testsuite, also includ