Re: [gofrontend-dev] Re: libgo patch committed: Implement reflect.MakeFunc for amd64

2013-11-12 Thread H.J. Lu
On Tue, Nov 12, 2013 at 2:23 PM, Ian Lance Taylor wrote: > On Tue, Nov 12, 2013 at 1:40 PM, H.J. Lu wrote: >> >> TestMakeFunc failed on x32: >> >> FAIL: TestMakeFunc (0.00 seconds) >> all_test.go:1457: Call returned 10, 20, 30, [40 0], 60, 70, 80; want 10, >> 20, 30, [40, 50], 60, 70, 80 >>

Re: [gofrontend-dev] Re: libgo patch committed: Implement reflect.MakeFunc for amd64

2013-11-12 Thread Ian Lance Taylor
On Tue, Nov 12, 2013 at 1:40 PM, H.J. Lu wrote: > > TestMakeFunc failed on x32: > > FAIL: TestMakeFunc (0.00 seconds) > all_test.go:1457: Call returned 10, 20, 30, [40 0], 60, 70, 80; want 10, > 20, 30, [40, 50], 60, 70, 80 > > The difference in x32 is x32 puts 2 pointers (32-bit) in one 64-g

Re: libgo patch committed: Implement reflect.MakeFunc for amd64

2013-11-12 Thread H.J. Lu
On Tue, Nov 12, 2013 at 1:40 PM, H.J. Lu wrote: > On Fri, Sep 27, 2013 at 10:54 AM, Ian Lance Taylor wrote: >> The Go standard library has an interesting function named >> reflect.MakeFunc. It takes a Go function F that accepts and returns a >> slice of reflect.Value, and a function type T, and

Re: libgo patch committed: Implement reflect.MakeFunc for amd64

2013-11-12 Thread H.J. Lu
On Fri, Sep 27, 2013 at 10:54 AM, Ian Lance Taylor wrote: > The Go standard library has an interesting function named > reflect.MakeFunc. It takes a Go function F that accepts and returns a > slice of reflect.Value, and a function type T, and returns a pointer to > a function of type T that conve

libgo patch committed: Implement reflect.MakeFunc for amd64

2013-09-27 Thread Ian Lance Taylor
The Go standard library has an interesting function named reflect.MakeFunc. It takes a Go function F that accepts and returns a slice of reflect.Value, and a function type T, and returns a pointer to a function of type T that converts its arguments to reflect.Value, calls F, and converts the retur