Re: libgo patch committed: Add timeout for tests

2011-04-04 Thread Rainer Orth
Mike Stump writes: >> Ok, I'll see how long they take on my 250 MHz R10k MIPS :-) > > I'd rather slow environments and slow machines setup a scaling factor with > which they can expand the time as needed. So, using a rs232 port at 110 to > download testcases, scaling_factor=1000 or so. That's

Re: libgo patch committed: Add timeout for tests

2011-04-04 Thread Rainer Orth
Mike Stump writes: >> Shouldn't the default match the DejaGnu default of 300, though? > > No... I like the idea that people trim it down to something sane. If > nothing else, as a way to discourage them from big stupid test cases. No argument from me, since I've often been bitten by slower te

Re: libgo patch committed: Add timeout for tests

2011-04-01 Thread Mike Stump
On Apr 1, 2011, at 7:21 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >>> Shouldn't the default match the DejaGnu default of 300, though? >> >> Sure, it could, but why? If any of these tests fail to complete in a >> minute, something is badly wrong. > > Ok, I'll see how long they take on

Re: libgo patch committed: Add timeout for tests

2011-04-01 Thread Mike Stump
On Apr 1, 2011, at 12:14 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> This patch to libgo adds a timeout for the libgo tests. The default is >> 60 seconds. It can be changed by an argument to gotest, which would >> normally be used as, e.g., >> make GOTESTFLAGS="--timeout=120" check-

Re: libgo patch committed: Add timeout for tests

2011-04-01 Thread Rainer Orth
Ian Lance Taylor writes: >> Shouldn't the default match the DejaGnu default of 300, though? > > Sure, it could, but why? If any of these tests fail to complete in a > minute, something is badly wrong. Ok, I'll see how long they take on my 250 MHz R10k MIPS :-) Rainer -- -

Re: libgo patch committed: Add timeout for tests

2011-04-01 Thread Ian Lance Taylor
Rainer Orth writes: > Ian Lance Taylor writes: > >> This patch to libgo adds a timeout for the libgo tests. The default is >> 60 seconds. It can be changed by an argument to gotest, which would >> normally be used as, e.g., >> make GOTESTFLAGS="--timeout=120" check-target-libgo > > Great, th

Re: libgo patch committed: Add timeout for tests

2011-04-01 Thread Rainer Orth
Ian Lance Taylor writes: > This patch to libgo adds a timeout for the libgo tests. The default is > 60 seconds. It can be changed by an argument to gotest, which would > normally be used as, e.g., > make GOTESTFLAGS="--timeout=120" check-target-libgo Great, thanks. Shouldn't the default mat

libgo patch committed: Add timeout for tests

2011-03-31 Thread Ian Lance Taylor
This patch to libgo adds a timeout for the libgo tests. The default is 60 seconds. It can be changed by an argument to gotest, which would normally be used as, e.g., make GOTESTFLAGS="--timeout=120" check-target-libgo Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to