Re: cleanup cross product code in VRP

2018-07-19 Thread Jeff Law
On 07/19/2018 03:06 AM, Aldy Hernandez wrote: > > > On 07/19/2018 04:18 AM, Richard Biener wrote: >> On Wed, Jul 18, 2018 at 2:05 PM Aldy Hernandez wrote: >>> >>> Hi again! >>> >>> Well, since this hasn't been reviewed and I'm about to overhaul the >>> TYPE_OVERFLOW_WRAPS code anyhow, might as w

Re: cleanup cross product code in VRP

2018-07-19 Thread Aldy Hernandez
On 07/19/2018 04:18 AM, Richard Biener wrote: On Wed, Jul 18, 2018 at 2:05 PM Aldy Hernandez wrote: Hi again! Well, since this hasn't been reviewed and I'm about to overhaul the TYPE_OVERFLOW_WRAPS code anyhow, might as well lump it all in one patch. On 07/16/2018 09:19 AM, Aldy Hernandez

Re: cleanup cross product code in VRP

2018-07-19 Thread Richard Biener
On Wed, Jul 18, 2018 at 2:05 PM Aldy Hernandez wrote: > > Hi again! > > Well, since this hasn't been reviewed and I'm about to overhaul the > TYPE_OVERFLOW_WRAPS code anyhow, might as well lump it all in one patch. > > On 07/16/2018 09:19 AM, Aldy Hernandez wrote: > > Howdy! > > > > I've abstracte

Re: cleanup cross product code in VRP

2018-07-18 Thread Aldy Hernandez
Hi again! Well, since this hasn't been reviewed and I'm about to overhaul the TYPE_OVERFLOW_WRAPS code anyhow, might as well lump it all in one patch. On 07/16/2018 09:19 AM, Aldy Hernandez wrote: Howdy! I've abstracted out the cross product calculations into its own function, and have adap

cleanup cross product code in VRP

2018-07-16 Thread Aldy Hernandez
Howdy! I've abstracted out the cross product calculations into its own function, and have adapted it to deal with wide ints so it's more reusable. It required some shuffling around, and implementing things a bit different, but things should be behave as before. I also renamed vrp_int_const_