Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-16 Thread Richard Sandiford
Richard Biener writes: > On Fri, Sep 13, 2013 at 10:33 AM, Richard Sandiford > wrote: >> Richard Biener writes: Yeah. I don't think it makes sense to canonise PSI to 32 bits when we know it has fewer than 32 bits. It's still going to be wrong, and will still defeat one of the ma

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-13 Thread Richard Biener
On Fri, Sep 13, 2013 at 10:33 AM, Richard Sandiford wrote: > Richard Biener writes: >>> Yeah. I don't think it makes sense to canonise PSI to 32 bits when we >>> know it has fewer than 32 bits. It's still going to be wrong, and will >>> still defeat one of the main purposes of canonical constan

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-13 Thread Richard Sandiford
Richard Biener writes: >> Yeah. I don't think it makes sense to canonise PSI to 32 bits when we >> know it has fewer than 32 bits. It's still going to be wrong, and will >> still defeat one of the main purposes of canonical constants, which is >> to make equality obvious. E.g. we'd still treat

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-13 Thread Richard Biener
On Fri, Sep 13, 2013 at 10:08 AM, Richard Sandiford wrote: > Richard Biener writes: (what about partial integer modes which have weird precision (none)?) >>> >>> We don't really model that properly yet. Partial modes are just defined >>> using something like: >>> >>> PARTIAL_INT_MODE (SI);

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-13 Thread Richard Sandiford
Richard Biener writes: >>> (what about partial integer modes which have weird precision (none)?) >> >> We don't really model that properly yet. Partial modes are just defined >> using something like: >> >> PARTIAL_INT_MODE (SI); >> >> i.e. without the partial precision. But trunc_int_for_mode is

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-13 Thread Richard Biener
On Thu, Sep 12, 2013 at 6:19 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Wed, Sep 11, 2013 at 8:39 PM, Richard Sandiford >> wrote: >>> Graham Stott writes: Hi Richard, There is some minor testsuite fallout with these patches on MIPS a couple of tests (see bel

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-12 Thread Richard Sandiford
Richard Biener writes: > On Wed, Sep 11, 2013 at 8:39 PM, Richard Sandiford > wrote: >> Graham Stott writes: >>> Hi Richard, >>> >>> There is some minor testsuite fallout with these patches on MIPS a >>> couple of tests (see below)ICE ingen_int_mode () in both these ICE the >>> mode is CCmode. >

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-12 Thread Graham Stott
Stott Cc: James Greenhalgh ; "gcc-patches@gcc.gnu.org" Sent: Wednesday, 11 September 2013, 19:39 Subject: Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS Graham Stott writes: > Hi Richard, > > There is some minor testsuite fallout with these patches

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-12 Thread Richard Biener
On Wed, Sep 11, 2013 at 8:39 PM, Richard Sandiford wrote: > Graham Stott writes: >> Hi Richard, >> >> There is some minor testsuite fallout with these patches on MIPS a >> couple of tests (see below)ICE ingen_int_mode () in both these ICE the >> mode is CCmode. > > Hmm, interesting. I suppose ge

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-11 Thread Graham Stott
Hi Richard, Thanks I'll give a go tomorrow. Not sure why it has only been seen/reported for MIPS so far I can't see why it can't happen in other backends. Cheers Graham

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-11 Thread Richard Sandiford
Graham Stott writes: > Hi Richard, > > There is some minor testsuite fallout with these patches on MIPS a > couple of tests (see below)ICE ingen_int_mode () in both these ICE the > mode is CCmode. Hmm, interesting. I suppose gen_int_mode should handle CC modes, since there's no other constant rt

Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-11 Thread Graham Stott
Hi Richard, There is some minor testsuite fallout with these patches on MIPS a couple of tests (see below)ICE ingen_int_mode () in both these ICE the mode is CCmode. Here we arrive at gen_int_mode () via a use of plus_constant () is cse.c with a register with CCmode called fromĀ  find_reg_offset