Re: Use correct location information for OpenACC shape and simple clauses in C/C++

2019-02-22 Thread Thomas Schwinge
Hi! On Thu, 4 Aug 2016 11:03:25 -0600, Jeff Law wrote: > On 07/27/2016 09:17 AM, Thomas Schwinge wrote: > > I found that for a lot of OpenACC (and potentially also OpenMP) clauses > > (in C/C++ front ends; didn't look at Fortran), we use wrong location > > information. The problem is that > > c_

Re: [patch,openacc] Use correct location information for OpenACC shape and simple, clauses in C/C++

2018-09-26 Thread Jason Merrill
The C++ change is OK. On Wed, Sep 26, 2018 at 2:41 PM, Cesar Philippidis wrote: > Thomas, this is your old gomp4 patch that updates the error locations > for gang, worker and vector clauses. Those functions are parsed in > {c,cp}_parser_oacc_shape_clause. I'm not sure how much of an impact this >

[patch,openacc] Use correct location information for OpenACC shape and simple, clauses in C/C++

2018-09-26 Thread Cesar Philippidis
it for x86_64 Linux with nvptx offloading. Cesar [OpenACC] Use correct location information for OpenACC shape and simple clauses in C/C++ 2018-XX-YY Thomas Schwinge Cesar Philippidis gcc/c/ * c-parser.c (c_parser_oacc_shape_clause) (c_parser_oacc_simple_clause): Add loc formal param

Re: [PING] Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-31 Thread Gerald Pfeifer
On Thu, 4 Aug 2016, David Malcolm wrote: > On Thu, 2016-08-04 at 16:54 +0200, Thomas Schwinge wrote: >> I think in your position as a maintainer for "diagnostic messages", >> you should be qualified to exercise that status to approve such a >> patch. :-) > I don't know exactly where the boundarie

Re: Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-16 Thread Thomas Schwinge
rect location information for OpenACC shape and simple clauses in C/C++ gcc/c/ * c-parser.c (c_parser_oacc_shape_clause) (c_parser_oacc_simple_clause): Add loc formal parameter. Adjust all users. gcc/cp/ * parser.c (cp_parser_oacc_shape_clause): Add

Re: Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-04 Thread Jeff Law
ementation" fix (wrong diagnostic locations)? commit bac4c04ca1d52c56a3583f5958e116c62b889d5a Author: Thomas Schwinge Date: Wed Jul 27 16:55:56 2016 +0200 Use correct location information for OpenACC shape and simple clauses in C/C++ gcc/c/

Re: [PING] Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-04 Thread David Malcolm
On Thu, 2016-08-04 at 16:54 +0200, Thomas Schwinge wrote: > Hi! > > On Wed, 27 Jul 2016 17:09:38 -0400, David Malcolm < > dmalc...@redhat.com> wrote: > > On Wed, 2016-07-27 at 17:17 +0200, Thomas Schwinge wrote: > > > I found that for a lot of OpenACC (and potentially also OpenMP) > > > clauses >

[PING] Use correct location information for OpenACC shape and simple clauses in C/C++

2016-08-04 Thread Thomas Schwinge
Hi! On Wed, 27 Jul 2016 17:09:38 -0400, David Malcolm wrote: > On Wed, 2016-07-27 at 17:17 +0200, Thomas Schwinge wrote: > > I found that for a lot of OpenACC (and potentially also OpenMP) > > clauses > > (in C/C++ front ends; didn't look at Fortran), we use wrong location > > information. The p

Re: Use correct location information for OpenACC shape and simple clauses in C/C++

2016-07-27 Thread David Malcolm
On Wed, 2016-07-27 at 17:17 +0200, Thomas Schwinge wrote: > Hi! > > I found that for a lot of OpenACC (and potentially also OpenMP) > clauses > (in C/C++ front ends; didn't look at Fortran), we use wrong location > information. The problem is that > c_parser_oacc_all_clauses/c_parser_omp_all_clau

Use correct location information for OpenACC shape and simple clauses in C/C++

2016-07-27 Thread Thomas Schwinge
commit bac4c04ca1d52c56a3583f5958e116c62b889d5a Author: Thomas Schwinge Date: Wed Jul 27 16:55:56 2016 +0200 Use correct location information for OpenACC shape and simple clauses in C/C++ gcc/c/ * c-parser.c (c_parser_oacc_shape_clause) (c_parser_oacc_s