Re: varpool/constpool bug

2016-01-08 Thread Richard Biener
On January 8, 2016 4:13:17 PM GMT+01:00, Jan Hubicka wrote: >> On 01/08/16 05:39, Richard Biener wrote: >> >> >Oh, and I _do_ belive that ultimatively we should have all constant >pool >> >entries (and CONST_DECLs) in the varpool. >> >> FWIW that certainly seems like the right goal. >Indeed it i

Re: varpool/constpool bug

2016-01-08 Thread Jan Hubicka
> On 01/08/16 05:39, Richard Biener wrote: > > >Oh, and I _do_ belive that ultimatively we should have all constant pool > >entries (and CONST_DECLs) in the varpool. > > FWIW that certainly seems like the right goal. Indeed it is on my TODO. I need to make CONST_DECLs to have visibility (so they

Re: varpool/constpool bug

2016-01-08 Thread Nathan Sidwell
On 01/08/16 05:39, Richard Biener wrote: Oh, and I _do_ belive that ultimatively we should have all constant pool entries (and CONST_DECLs) in the varpool. FWIW that certainly seems like the right goal. nathan

Re: varpool/constpool bug

2016-01-08 Thread Richard Biener
On Mon, Jan 4, 2016 at 7:53 PM, Jeff Law wrote: > On 01/04/2016 08:57 AM, Nathan Sidwell wrote: >> >> My patch to stop constant pool objects accidentally ending up in the >> varpool caused problems with (at least) powerpc. >> (https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02100.html) Hence reverte

Re: varpool/constpool bug

2016-01-04 Thread Jeff Law
On 01/04/2016 08:57 AM, Nathan Sidwell wrote: My patch to stop constant pool objects accidentally ending up in the varpool caused problems with (at least) powerpc. (https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02100.html) Hence reverted. This patch changes compare_base_decls to simply use the v

Re: varpool/constpool bug

2016-01-04 Thread Nathan Sidwell
My patch to stop constant pool objects accidentally ending up in the varpool caused problems with (at least) powerpc. (https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02100.html) Hence reverted. This patch changes compare_base_decls to simply use the varpool getter, rather than get_create. We s

Re: varpool/constpool bug

2015-12-23 Thread Nathan Sidwell
On 12/23/15 09:48, Nathan Sidwell wrote: On 12/21/15 14:45, Jeff Law wrote: With some kind of comment in decl_in_symtab_p indicating why we need to check and filter on !DECL_IN_CONSTANT_POOL this is OK. Done, thanks. (I half guessed HPPA might be such a port :) sigh, there are other route

Re: varpool/constpool bug

2015-12-23 Thread Nathan Sidwell
On 12/21/15 14:45, Jeff Law wrote: With some kind of comment in decl_in_symtab_p indicating why we need to check and filter on !DECL_IN_CONSTANT_POOL this is OK. Done, thanks. (I half guessed HPPA might be such a port :) nathan 2015-12-23 Nathan Sidwell gcc/ * alias.c (compare_base_de

Re: varpool/constpool bug

2015-12-21 Thread Jeff Law
On 12/19/2015 09:47 AM, Nathan Sidwell wrote: Either build_constant_desc (varasm.c) should put constants into the varpool or decl_in_symtab_p should ignore constant pool VAR_DECLS. It appears to me that the latter is the right choice, as constant pool entries can't be related to regular varpool