Re: skip asan-poisoning of discarded vars

2021-01-22 Thread Jakub Jelinek via Gcc-patches
On Thu, Jan 21, 2021 at 07:42:43PM -0300, Alexandre Oliva wrote: > On Jan 21, 2021, Alexandre Oliva wrote: > > > But I was wrong. The bootstrap with the added assert has just failed, > > as early as stage2 libiberty. Looking into it... > > Uhh, I take that back. I just goofed in the assert, i

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Alexandre Oliva wrote: > On Jan 21, 2021, Alexandre Oliva wrote: >> But I was wrong. The bootstrap with the added assert has just failed, >> as early as stage2 libiberty. Looking into it... > Uhh, I take that back. I just goofed in the assert, inverting the > condition. Lon

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Alexandre Oliva wrote: > But I was wrong. The bootstrap with the added assert has just failed, > as early as stage2 libiberty. Looking into it... Uhh, I take that back. I just goofed in the assert, inverting the condition. Long day... With the correct condition, it's got pa

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Jakub Jelinek wrote: > Does that affect only Ada and not other languages? I haven't observed it on other languages, but I didn't try really hard. Doing that now, with an assert that the newly-added condition doesn't ever hit. I'd already completed a bootstrap-asan the other day

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Jakub Jelinek via Gcc-patches
On Thu, Jan 21, 2021 at 06:30:06PM -0300, Alexandre Oliva wrote: > > GNAT may create temporaries to hold return values of function calls. > If such a temporary is created as part of a dynamic initializer of a > variable in a unit other than the one being compiled, the initializer > is dropped, inc