Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-10-07 Thread Ian Lance Taylor
On Mon, Oct 7, 2013 at 5:24 AM, Rainer Orth wrote: > > Unfortunately, Solaris 9 testing with Sun as revealed two problems: that > assembler cannot handle either # comments or .global instead of .globl. > The following patch fixes this and allows makefunc_386.S to assemble. > Also compiled with a

Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-10-07 Thread Rainer Orth
Ian Lance Taylor writes: > On Wed, Oct 2, 2013 at 7:45 AM, Rainer Orth > wrote: >> >> Here's what I came up with. As I said, it is inspired by the libffi >> code, but a bit simplified since e.g. stuff like no .ascii support >> aren't relevant on the Solaris versions supported on mainline and 4

Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-10-02 Thread Ian Lance Taylor
On Wed, Oct 2, 2013 at 7:45 AM, Rainer Orth wrote: > > Here's what I came up with. As I said, it is inspired by the libffi > code, but a bit simplified since e.g. stuff like no .ascii support > aren't relevant on the Solaris versions supported on mainline and 4.8 > branch. > > Bootstrapped on x8

Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-10-02 Thread Rainer Orth
Ian Lance Taylor writes: > On Mon, Sep 30, 2013 at 7:07 AM, Rainer Orth > wrote: >> Ian Lance Taylor writes: >> >>> On Mon, Sep 30, 2013 at 6:07 AM, Rainer Orth >>> wrote: Ian Lance Taylor writes: > Following up on my earlier patch, this patch implements the > reflect.MakeFu

Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-09-30 Thread Ian Lance Taylor
On Mon, Sep 30, 2013 at 7:07 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> On Mon, Sep 30, 2013 at 6:07 AM, Rainer Orth >> wrote: >>> Ian Lance Taylor writes: >>> Following up on my earlier patch, this patch implements the reflect.MakeFunc function for 386. Tom Trom

Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-09-30 Thread Rainer Orth
Ian Lance Taylor writes: > On Mon, Sep 30, 2013 at 6:07 AM, Rainer Orth > wrote: >> Ian Lance Taylor writes: >> >>> Following up on my earlier patch, this patch implements the >>> reflect.MakeFunc function for 386. >>> >>> Tom Tromey pointed out to me that the libffi closure support can >>> pro

Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-09-30 Thread Ian Lance Taylor
On Mon, Sep 30, 2013 at 6:07 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> Following up on my earlier patch, this patch implements the >> reflect.MakeFunc function for 386. >> >> Tom Tromey pointed out to me that the libffi closure support can >> probably be used for this. I was not awa

Re: libgo patch committed: Implement reflect.MakeFunc for 386

2013-09-30 Thread Rainer Orth
Ian Lance Taylor writes: > Following up on my earlier patch, this patch implements the > reflect.MakeFunc function for 386. > > Tom Tromey pointed out to me that the libffi closure support can > probably be used for this. I was not aware of that support. It > supports a lot more processors, and