Re: libgo patch committed: Force LANG=C when looking for compiler version

2018-03-16 Thread Andreas Schwab
On Mär 15 2018, Ian Lance Taylor wrote: > On Thu, Mar 15, 2018 at 11:24 AM, Andreas Schwab > wrote: >> On Mär 15 2018, Ian Lance Taylor wrote: >> >>> On Thu, Mar 15, 2018 at 10:10 AM, Andreas Schwab >>> wrote: On Mär 15 2018, Ian Lance Taylor wrote: > + env = append(env, "

Re: libgo patch committed: Force LANG=C when looking for compiler version

2018-03-15 Thread Ian Lance Taylor
On Thu, Mar 15, 2018 at 11:24 AM, Andreas Schwab wrote: > On Mär 15 2018, Ian Lance Taylor wrote: > >> On Thu, Mar 15, 2018 at 10:10 AM, Andreas Schwab >> wrote: >>> On Mär 15 2018, Ian Lance Taylor wrote: >>> + env = append(env, "LANG=C") >>> >>> You should use LC_ALL=C instead. >> >

Re: libgo patch committed: Force LANG=C when looking for compiler version

2018-03-15 Thread Andreas Schwab
On Mär 15 2018, Ian Lance Taylor wrote: > On Thu, Mar 15, 2018 at 10:10 AM, Andreas Schwab > wrote: >> On Mär 15 2018, Ian Lance Taylor wrote: >> >>> + env = append(env, "LANG=C") >> >> You should use LC_ALL=C instead. > > Does it really matter? Do you think that this approach won't work?

Re: libgo patch committed: Force LANG=C when looking for compiler version

2018-03-15 Thread Ian Lance Taylor
On Thu, Mar 15, 2018 at 10:10 AM, Andreas Schwab wrote: > On Mär 15 2018, Ian Lance Taylor wrote: > >> + env = append(env, "LANG=C") > > You should use LC_ALL=C instead. Does it really matter? Do you think that this approach won't work? Ian

Re: libgo patch committed: Force LANG=C when looking for compiler version

2018-03-15 Thread Andreas Schwab
On Mär 15 2018, Ian Lance Taylor wrote: > + env = append(env, "LANG=C") You should use LC_ALL=C instead. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."