Re: libgo patch committed: Adjust libbacktrace PC value in runtime_callers callback

2015-04-17 Thread Ian Lance Taylor
On Fri, Apr 17, 2015 at 1:03 PM, wrote: > On 04/17/2015 01:29 PM, Ian Lance Taylor wrote: >> >> The libbacktrace library returns a PC that was (usually) decremented >> to be part of the call instruction. The Go code that uses >> runtime.Callers does not expect this, and Go code that adjusts the

Re: libgo patch committed: Adjust libbacktrace PC value in runtime_callers callback

2015-04-17 Thread msebor
On 04/17/2015 01:29 PM, Ian Lance Taylor wrote: The libbacktrace library returns a PC that was (usually) decremented to be part of the call instruction. The Go code that uses runtime.Callers does not expect this, and Go code that adjusts the PC value, such as libgo/go/runtime/pprof/pprof.go, can