Re: introduce target tmpnam and require it in tests relying on it

2020-04-29 Thread Jeff Law via Gcc-patches
On Tue, 2020-04-28 at 20:43 -0300, Alexandre Oliva wrote: > On Apr 28, 2020, Bernhard Reutner-Fischer wrote: > > > ISTM the corresponding documentation hunk for sourcebuild.texi is missing. > > Thanks, I wasn't aware that testsuite effective targets were documented > there. > > Here's the miss

Re: introduce target tmpnam and require it in tests relying on it

2020-04-28 Thread Alexandre Oliva
On Apr 28, 2020, Bernhard Reutner-Fischer wrote: > ISTM the corresponding documentation hunk for sourcebuild.texi is missing. Thanks, I wasn't aware that testsuite effective targets were documented there. Here's the missing documentation. Tested with 'make info' on x86_64-linux-gnu. Ok to in

Re: introduce target tmpnam and require it in tests relying on it

2020-04-28 Thread Bernhard Reutner-Fischer via Gcc-patches
On 24 April 2020 11:59:50 CEST, Alexandre Oliva wrote: >On Apr 23, 2020, Martin Sebor wrote: > >> Sure. I'd go with _fileio but that's just a suggestion. > >Okiedokie, here's the patch using fileio instead of tmpnam for the >effective target name. I'm going to check it in shortly. > > >introduc

Re: introduce target tmpnam and require it in tests relying on it

2020-04-24 Thread Alexandre Oliva
On Apr 23, 2020, Martin Sebor wrote: > Sure. I'd go with _fileio but that's just a suggestion. Okiedokie, here's the patch using fileio instead of tmpnam for the effective target name. I'm going to check it in shortly. introduce target fileio and require it in tests that use tmpnam Some tar

Re: introduce target tmpnam and require it in tests relying on it

2020-04-23 Thread Martin Sebor via Gcc-patches
On 4/23/20 2:21 AM, Alexandre Oliva wrote: On Apr 21, 2020, Bernhard Reutner-Fischer wrote: On 17 April 2020 21:21:41 CEST, Martin Sebor via Gcc-patches wrote: On 4/17/20 11:48 AM, Alexandre Oliva wrote: On Apr 9, 2020, Alexandre Oliva wrote: Some target C libraries that aren't recogniz

Re: introduce target tmpnam and require it in tests relying on it

2020-04-23 Thread Alexandre Oliva
On Apr 21, 2020, Bernhard Reutner-Fischer wrote: > On 17 April 2020 21:21:41 CEST, Martin Sebor via Gcc-patches > wrote: >> On 4/17/20 11:48 AM, Alexandre Oliva wrote: >>> On Apr 9, 2020, Alexandre Oliva wrote: >>> Some target C libraries that aren't recognized as freestanding don't

Re: introduce target tmpnam and require it in tests relying on it

2020-04-22 Thread Jeff Law via Gcc-patches
On Fri, 2020-04-17 at 14:48 -0300, Alexandre Oliva wrote: > On Apr 9, 2020, Alexandre Oliva wrote: > > > Some target C libraries that aren't recognized as freestanding don't > > have filesystem support, so calling tmpnam, fopen/open and > > remove/unlink fails to link. > > This patch introduces

Re: introduce target tmpnam and require it in tests relying on it

2020-04-22 Thread Martin Sebor via Gcc-patches
On 4/22/20 2:03 AM, Bernhard Reutner-Fischer wrote: On Tue, 21 Apr 2020 at 16:59, Martin Sebor wrote: https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543672.html I'm okay with the changes to the tests. The target-supports.exp changes look reasonable to me as well but I can't approve th

Re: introduce target tmpnam and require it in tests relying on it

2020-04-22 Thread Bernhard Reutner-Fischer via Gcc-patches
On Tue, 21 Apr 2020 at 16:59, Martin Sebor wrote: > >>> https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543672.html > >> > >> I'm okay with the changes to the tests. > >> > >> The target-supports.exp changes look reasonable to me as well but > >> I can't approve them. Since you said it's fo

Re: introduce target tmpnam and require it in tests relying on it

2020-04-21 Thread Martin Sebor via Gcc-patches
On 4/21/20 3:50 AM, Bernhard Reutner-Fischer wrote: On 17 April 2020 21:21:41 CEST, Martin Sebor via Gcc-patches wrote: On 4/17/20 11:48 AM, Alexandre Oliva wrote: On Apr 9, 2020, Alexandre Oliva wrote: Some target C libraries that aren't recognized as freestanding don't have filesystem s

Re: introduce target tmpnam and require it in tests relying on it

2020-04-21 Thread Bernhard Reutner-Fischer via Gcc-patches
On 17 April 2020 21:21:41 CEST, Martin Sebor via Gcc-patches wrote: >On 4/17/20 11:48 AM, Alexandre Oliva wrote: >> On Apr 9, 2020, Alexandre Oliva wrote: >> >>> Some target C libraries that aren't recognized as freestanding don't >>> have filesystem support, so calling tmpnam, fopen/open and

Re: introduce target tmpnam and require it in tests relying on it

2020-04-17 Thread Martin Sebor via Gcc-patches
On 4/17/20 11:48 AM, Alexandre Oliva wrote: On Apr 9, 2020, Alexandre Oliva wrote: Some target C libraries that aren't recognized as freestanding don't have filesystem support, so calling tmpnam, fopen/open and remove/unlink fails to link. This patch introduces a tmpnam effective target to

Re: introduce target tmpnam and require it in tests relying on it

2020-04-17 Thread Alexandre Oliva
On Apr 9, 2020, Alexandre Oliva wrote: > Some target C libraries that aren't recognized as freestanding don't > have filesystem support, so calling tmpnam, fopen/open and > remove/unlink fails to link. > This patch introduces a tmpnam effective target to the testsuite, and > requires it in the