Re: empty range in pop_heap

2011-12-04 Thread Jonathan Wakely
On 4 December 2011 09:37, Markus Trippelsdorf wrote: > > You forgot to change the second one with the comparison functor. Doh! Thanks, fixed now. * include/bits/stl_heap.h (pop_heap): Check for non-empty range in overload taking a predicate. * testsuite/25_algorithms/pop_h

Re: empty range in pop_heap

2011-12-04 Thread Markus Trippelsdorf
On 2011.12.03 at 15:35 +, Jonathan Wakely wrote: > On 12 November 2011 15:14, Jonathan Wakely wrote: > > On 12 November 2011 15:04, Marc Glisse wrote: > >> > >> Debug-mode seems to check that first,last is a valid range, is a heap, but > >> not that it is not empty. Maybe it could? > > > > Good

Re: empty range in pop_heap

2011-12-03 Thread Jonathan Wakely
On 12 November 2011 15:14, Jonathan Wakely wrote: > On 12 November 2011 15:04, Marc Glisse wrote: >> >> Debug-mode seems to check that first,last is a valid range, is a heap, but >> not that it is not empty. Maybe it could? > > Good idea, thanks.  I'll change that. As promised. * include/