Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-19 Thread Jim Meyering
Michael Matz wrote: > On Mon, 18 Apr 2011, Janne Blomqvist wrote: > >> (Why we, in the age of non-sucky version control, persist in keeping >> manual changelog files is beyond me..) > > The one single reason why I'm very happy about our ChangeLog file policy > is that I can grep it easily. Listing

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-19 Thread Michael Matz
Hi, On Mon, 18 Apr 2011, Janne Blomqvist wrote: > (Why we, in the age of non-sucky version control, persist in keeping > manual changelog files is beyond me..) The one single reason why I'm very happy about our ChangeLog file policy is that I can grep it easily. Listing the changelog of the w

Re: [PATCH v4] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Tom Tromey wrote: >> "Jim" == Jim Meyering writes: > > Jim> Since v3, I've rebased these and moved the fortran changes to precede > Jim> these (changing gfc_free to free introduced a few more instances > Jim> that this transformation deals with). As mentioned before, the > Jim> conditional-re

Re: [PATCH v4] Re: avoid useless if-before-free tests

2011-04-18 Thread Tom Tromey
> "Jim" == Jim Meyering writes: Jim> Since v3, I've rebased these and moved the fortran changes to precede Jim> these (changing gfc_free to free introduced a few more instances Jim> that this transformation deals with). As mentioned before, the Jim> conditional-removing transformation was do

[PATCH v4] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Since v3, I've rebased these and moved the fortran changes to precede these (changing gfc_free to free introduced a few more instances that this transformation deals with). As mentioned before, the conditional-removing transformation was done mechanically with two manual corrections. One to deal

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Janne Blomqvist wrote: > On Mon, Apr 18, 2011 at 18:08, Jim Meyering wrote: >> I've rebased and divided/reordered these changes as you suggested. >> Here are the fortran parts.  I'll post the other parts separately. >> Parts 1 and 3 are manual.  Part 2 is the big mechanical change with >> two man

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-18 Thread Janne Blomqvist
On Mon, Apr 18, 2011 at 18:08, Jim Meyering wrote: > I've rebased and divided/reordered these changes as you suggested. > Here are the fortran parts.  I'll post the other parts separately. > Parts 1 and 3 are manual.  Part 2 is the big mechanical change with > two manual adjustments: > >  [PATCH 1

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Janne Blomqvist wrote: > On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: >> Janne Blomqvist wrote: >>> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: Relative to v2, I've added libgo/ to the list of exempt directories and added this recently discussed gfc_free patch, at the

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Jim Meyering
> I added Jim to the gcc group. Thanks, Tom.

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Tom Tromey
> "Janne" == Janne Blomqvist writes: Jim> Can someone add me to the gcc group?  That would help. Jim> I already have ssh access to sourceware.org. Janne> I'm not sure if I'm considered to be well-established Janne> enough, so could someone help Jim out here, please? I added Jim to the gcc g

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Jim Meyering
Janne Blomqvist wrote: > On Fri, Apr 15, 2011 at 10:54, Jim Meyering wrote: >> Janne Blomqvist wrote: >> >>> On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: Janne Blomqvist wrote: > On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: >> Relative to v2, I've added libgo/ to the list

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Janne Blomqvist
On Fri, Apr 15, 2011 at 10:54, Jim Meyering wrote: > Janne Blomqvist wrote: > >> On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: >>> Janne Blomqvist wrote: On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: > Relative to v2, I've added libgo/ to the list of exempt directories and >>>

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Jim Meyering
Janne Blomqvist wrote: > On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: >> Janne Blomqvist wrote: >>> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: Relative to v2, I've added libgo/ to the list of exempt directories and added this recently discussed gfc_free patch, at the

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-15 Thread Janne Blomqvist
On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: > Janne Blomqvist wrote: >> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: >>> Relative to v2, I've added libgo/ to the list of exempt directories and >>> added >>> this recently discussed gfc_free patch, at the request of Tobias Burnus. >>>

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-03-24 Thread Jim Meyering
Janne Blomqvist wrote: > On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: >> Relative to v2, I've added libgo/ to the list of exempt directories and added >> this recently discussed gfc_free patch, at the request of Tobias Burnus. >> Also, I corrected an error in fortran's ChangeLog and removed a

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-03-15 Thread Janne Blomqvist
On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: > Relative to v2, I've added libgo/ to the list of exempt directories and added > this recently discussed gfc_free patch, at the request of Tobias Burnus. > Also, I corrected an error in fortran's ChangeLog and removed all > whitespace changes from

Re: avoid useless if-before-free tests

2011-03-09 Thread Richard Guenther
On Tue, Mar 8, 2011 at 5:34 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/05/11 07:05, Jim Meyering wrote: >> Hello, >> >> Someone asked me about this yesterday, and since I've been carrying >> this patch series for over a year -- it's not high priority -- >> this

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 08:20:22PM +0100, Rainer Orth wrote: > Jim Meyering writes: > > >> I honestly don't see the point of this whitespace change unless done > >> across all ChangeLogs, not just a few that you happen to touch. > > > > As I said, it's gone, now, from my patch. > > If no one obje

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-03-08 Thread DJ Delorie
I'm OK with the libiberty parts.

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: >> I honestly don't see the point of this whitespace change unless done >> across all ChangeLogs, not just a few that you happen to touch. > > As I said, it's gone, now, from my patch. > If no one objects, I'll normalize all ChangeLog files. No objection per se, although it'

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Rainer Orth wrote: > Jim Meyering writes: >>> the change at hand. And please don't change the alignment of entries >>> with multiple email addresses. >> >> Changing 8-spaces to a TAB does not affect alignment when you're >> looking at the ChangeLog file itself with standard tab setting. >> >> Per

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: >> the change at hand. And please don't change the alignment of entries >> with multiple email addresses. > > Changing 8-spaces to a TAB does not affect alignment when you're > looking at the ChangeLog file itself with standard tab setting. > > Perhaps you looked at a hunk l

[PATCH v3] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Jim Meyering wrote: > Joseph S. Myers wrote: > ... >> We definitely don't want to make local changes to zlib for this sort of >> issue, though importing a new upstream version of zlib (making sure the >> local configure code still works) should be fine for 4.7. > > Thanks again for the feedback. >

Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Dr Andrew John Hughes wrote: > On 22:47 Mon 07 Mar , Joseph S. Myers wrote: >> On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote: >> >> > > http://gcc.gnu.org/codingconventions.html says Classpath changes should >> > > go >> > > via Classpath upstream, not directly into GCC. I don't know if tha

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Rainer Orth wrote: > Jim Meyering writes: >> I've taken the liberty of letting my editor remove trailing >> blanks in ChangeLog files. I hope that's ok. Also in ChangeLogs, >> I converted some leading 8-space (and 7-space) sequences to single TABs. > > Please move this to a separate patch: this

Re: avoid useless if-before-free tests

2011-03-08 Thread Dr Andrew John Hughes
On 22:47 Mon 07 Mar , Joseph S. Myers wrote: > On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote: > > > > http://gcc.gnu.org/codingconventions.html says Classpath changes should > > > go > > > via Classpath upstream, not directly into GCC. I don't know if that's > > > still accurate. > > >

Re: avoid useless if-before-free tests

2011-03-08 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/11 07:05, Jim Meyering wrote: > Hello, > > Someone asked me about this yesterday, and since I've been carrying > this patch series for over a year -- it's not high priority -- > this seems like a good time finally to post it. > > I've been r

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:28:37AM -0800, Ian Lance Taylor wrote: > Rainer Orth writes: > > >> I found no ChangeLog for libgo and no other libgo-related entries. > >> I suspect that means I should omit this change because it belongs upstream. > > > > Indeed, cf. libgo/README*. I've Cc'ed Ian who

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Ian Lance Taylor
Rainer Orth writes: >> I found no ChangeLog for libgo and no other libgo-related entries. >> I suspect that means I should omit this change because it belongs upstream. > > Indeed, cf. libgo/README*. I've Cc'ed Ian who maintains this part of > GCC. Yes, libgo is upstream but in any case I'd pre

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Rainer Orth
Jim Meyering writes: > I've taken the liberty of letting my editor remove trailing > blanks in ChangeLog files. I hope that's ok. Also in ChangeLogs, > I converted some leading 8-space (and 7-space) sequences to single TABs. Please move this to a separate patch: this is completely unrelated to

Re: avoid useless if-before-free tests

2011-03-08 Thread Jim Meyering
Joseph S. Myers wrote: Thank you for the prompt feedback. > On Sat, 5 Mar 2011, Jim Meyering wrote: > >> diff --git a/gcc/config/i386/gmm_malloc.h b/gcc/config/i386/gmm_malloc.h >> index 7a7e840..8993fc7 100644 >> --- a/gcc/config/i386/gmm_malloc.h >> +++ b/gcc/config/i386/gmm_malloc.h >> @@ -67,

Re: avoid useless if-before-free tests

2011-03-07 Thread Paolo Carlini
On 03/05/2011 03:05 PM, Jim Meyering wrote: > diff --git a/libstdc++-v3/libsupc++/del_opnt.cc > b/libstdc++-v3/libsupc++/del_opnt.cc > index 75051d5..29eab10 100644 > --- a/libstdc++-v3/libsupc++/del_opnt.cc > +++ b/libstdc++-v3/libsupc++/del_opnt.cc > @@ -31,6 +31,5 @@ extern "C" void free (void

Re: avoid useless if-before-free tests

2011-03-07 Thread Joseph S. Myers
On Mon, 7 Mar 2011, Dr Andrew John Hughes wrote: > > http://gcc.gnu.org/codingconventions.html says Classpath changes should go > > via Classpath upstream, not directly into GCC. I don't know if that's > > still accurate. > > > > That's still true. This seems to be the first message I've rec

Re: avoid useless if-before-free tests

2011-03-07 Thread Dr Andrew John Hughes
On 19:16 Sat 05 Mar , Joseph S. Myers wrote: > On Sat, 5 Mar 2011, Jim Meyering wrote: > > > diff --git a/gcc/config/i386/gmm_malloc.h b/gcc/config/i386/gmm_malloc.h > > index 7a7e840..8993fc7 100644 > > --- a/gcc/config/i386/gmm_malloc.h > > +++ b/gcc/config/i386/gmm_malloc.h > > @@ -67,8 +67

Re: avoid useless if-before-free tests

2011-03-05 Thread Joseph S. Myers
On Sat, 5 Mar 2011, Jim Meyering wrote: > diff --git a/intl/bindtextdom.c b/intl/bindtextdom.c > index 6faac57..ba3cc9a 100644 Sorry, missed these in the first pass; intl/ is another case where we wouldn't want to patch this locally. An import of updated libintl from newer upstream gettext wou

Re: avoid useless if-before-free tests

2011-03-05 Thread Joseph S. Myers
On Sat, 5 Mar 2011, Jim Meyering wrote: > diff --git a/gcc/config/i386/gmm_malloc.h b/gcc/config/i386/gmm_malloc.h > index 7a7e840..8993fc7 100644 > --- a/gcc/config/i386/gmm_malloc.h > +++ b/gcc/config/i386/gmm_malloc.h > @@ -67,8 +67,7 @@ _mm_malloc (size_t size, size_t align) > static __inline