Re: Try to update dominance info in tree-call-cdce.c

2015-11-02 Thread Jeff Law
On 11/02/2015 08:53 AM, Richard Sandiford wrote: Steven Bosscher writes: On Fri, Oct 30, 2015 at 2:11 PM, Richard Sandiford wrote: Is the split_block change really so bad? IMHO: Yes. Fair enough :-) I tend to agree. If the caller needs a more complex control flow and dominance/post-domi

Re: Try to update dominance info in tree-call-cdce.c

2015-11-02 Thread Richard Sandiford
Steven Bosscher writes: > On Fri, Oct 30, 2015 at 2:11 PM, Richard Sandiford > wrote: >> Is the split_block change really so bad? > > IMHO: Yes. Fair enough :-) > split_block just splits some basic block B into two blocks B1/B2 > somewhere in the middle of B. The dominance relations between B1

Re: Try to update dominance info in tree-call-cdce.c

2015-10-31 Thread Steven Bosscher
On Fri, Oct 30, 2015 at 2:11 PM, Richard Sandiford wrote: > Is the split_block change really so bad? IMHO: Yes. split_block just splits some basic block B into two blocks B1/B2 somewhere in the middle of B. The dominance relations between B1 and B2 are obvious and intuitive. The new flag to spli

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 1:14 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >>> wrote: The pass would free the dominance info after making a change, but it should be pretty easy to keep the info

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 1:14 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford >> wrote: >>> The pass would free the dominance info after making a change, but it >>> should be pretty easy to keep the information up-to-date when the call

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford > wrote: >> The pass would free the dominance info after making a change, but it >> should be pretty easy to keep the information up-to-date when the call >> has no EH edges. In a way the main hurdle was split_block, wh

Re: Try to update dominance info in tree-call-cdce.c

2015-10-30 Thread Richard Biener
On Fri, Oct 30, 2015 at 12:18 PM, Richard Sandiford wrote: > The pass would free the dominance info after making a change, but it > should be pretty easy to keep the information up-to-date when the call > has no EH edges. In a way the main hurdle was split_block, which seemed > to assume that the