Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Richard Henderson
On 04/25/12 11:46, Jan Hubicka wrote: >>> On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: + /* Return true when there are references to NODE. */ + + static bool + referred_to_p (symtab_node node) + { + int i; + struct ipa_ref *ref; + + for (i

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
> > On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: > > > + /* Return true when there are references to NODE.  */ > > > + > > > + static bool > > > + referred_to_p (symtab_node node) > > > + { > > > +   int i; > > > +   struct ipa_ref *ref; > > > + > > > +   for (i = 0; ipa_ref_list_referring_

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
> On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: > > + /* Return true when there are references to NODE.  */ > > + > > + static bool > > + referred_to_p (symtab_node node) > > + { > > +   int i; > > +   struct ipa_ref *ref; > > + > > +   for (i = 0; ipa_ref_list_referring_iterate (&node->symb

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Steven Bosscher
On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: > + /* Return true when there are references to NODE.  */ > + > + static bool > + referred_to_p (symtab_node node) > + { > +   int i; > +   struct ipa_ref *ref; > + > +   for (i = 0; ipa_ref_list_referring_iterate (&node->symbol.ref_list, i, > r

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
Hi, the fortran problem is caused by fact that fortran does nested funtions that are static constructors. I did not really think of that case in cgraph construction code. Fixed thus. Honza PR middle-end/53089 * cgraphunit.c (cgraph_process_new_functions): Do not enqueue new fun

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
> This caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53088 > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53089 The first one seems just moved warning because of different gimplification order. Fixed thus. Note that the warning comes out at weird place with input_location, but that pro

Re: Symbol table 13/many: reachability code rewrite

2012-04-23 Thread H.J. Lu
On Sun, Apr 22, 2012 at 2:16 PM, Jan Hubicka wrote: > Hi, > this is second part of cleanup of the callgraph/varpool reachability code. > > As I wrote in previous email, the callgraph was originally written with > reachability code built in. This code was used by non-unit-at-a-time (to drop > unnec