Re: Review Hashtable extract node API

2019-06-20 Thread François Dumont
On 6/19/19 12:47 AM, Jonathan Wakely wrote: On 18/06/19 22:42 +0200, François Dumont wrote: On 6/18/19 12:54 PM, Jonathan Wakely wrote: On 18/06/19 07:52 +0200, François Dumont wrote: A small regression noticed while merging. We shouldn't keep on using a moved-from key_type instance. Ok to c

Re: Review Hashtable extract node API

2019-06-18 Thread Jonathan Wakely
On 18/06/19 22:42 +0200, François Dumont wrote: On 6/18/19 12:54 PM, Jonathan Wakely wrote: On 18/06/19 07:52 +0200, François Dumont wrote: A small regression noticed while merging. We shouldn't keep on using a moved-from key_type instance. Ok to commit ? Feel free to do it if you prefer, I'l

Re: Review Hashtable extract node API

2019-06-18 Thread François Dumont
On 6/18/19 12:54 PM, Jonathan Wakely wrote: On 18/06/19 07:52 +0200, François Dumont wrote: A small regression noticed while merging. We shouldn't keep on using a moved-from key_type instance. Ok to commit ? Feel free to do it if you prefer, I'll do so at end of Europe day otherwise. diff

Re: Review Hashtable extract node API

2019-06-18 Thread Jonathan Wakely
On 18/06/19 07:52 +0200, François Dumont wrote: A small regression noticed while merging. We shouldn't keep on using a moved-from key_type instance. Ok to commit ? Feel free to do it if you prefer, I'll do so at end of Europe day otherwise. diff --git a/libstdc++-v3/include/bits/hashtable_

Re: Review Hashtable extract node API

2019-06-17 Thread François Dumont
A small regression noticed while merging. We shouldn't keep on using a moved-from key_type instance. Ok to commit ? Feel free to do it if you prefer, I'll do so at end of Europe day otherwise. François On 6/17/19 12:28 PM, Jonathan Wakely wrote: On 07/06/19 18:39 +0200, François Dumont wro

Re: Review Hashtable extract node API

2019-06-17 Thread Jonathan Wakely
On 07/06/19 18:39 +0200, François Dumont wrote: On 6/5/19 6:22 PM, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: Hi     Here is a patch to enhance the _Hashtable extract node API and fix a FIXME request.     The enhancement to the extract node Api is that extract(co

Re: Review Hashtable extract node API

2019-06-07 Thread François Dumont
On 6/5/19 6:22 PM, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: Hi     Here is a patch to enhance the _Hashtable extract node API and fix a FIXME request.     The enhancement to the extract node Api is that extract(const key_type&) do not call extract(const_iterato

Re: Review Hashtable extract node API

2019-06-06 Thread Jonathan Wakely
On 05/06/19 20:18 +0100, Jonathan Wakely wrote: On 05/06/19 17:43 +0100, Jonathan Wakely wrote: On 05/06/19 17:22 +0100, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: @@ -669,18 +670,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __node_base* _M_get_previous_node(size_ty

Re: Review Hashtable extract node API

2019-06-05 Thread Jonathan Wakely
On 05/06/19 17:43 +0100, Jonathan Wakely wrote: On 05/06/19 17:22 +0100, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: @@ -669,18 +670,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __node_base* _M_get_previous_node(size_type __bkt, __node_base* __n); - // Insert

Re: Review Hashtable extract node API

2019-06-05 Thread Jonathan Wakely
On 05/06/19 17:22 +0100, Jonathan Wakely wrote: On 04/06/19 19:19 +0200, François Dumont wrote: @@ -669,18 +670,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __node_base* _M_get_previous_node(size_type __bkt, __node_base* __n); - // Insert node with hash code __code, in bucket bkt if no

Re: Review Hashtable extract node API

2019-06-05 Thread Jonathan Wakely
On 04/06/19 19:19 +0200, François Dumont wrote: Hi     Here is a patch to enhance the _Hashtable extract node API and fix a FIXME request.     The enhancement to the extract node Api is that extract(const key_type&) do not call extract(const_iterator) anymore. Doing so we had to loop again