Re: Re: [committed] RISC-V: Add crypto vector builtin function.

2024-01-05 Thread 钟居哲
Thanks Jeff. Yeah, I aggree we are not doing thing terribly wrong but Palmer request revert of the vector-crypto, so I revert it (actually, I asked Li Pan revert it). Actually, Wang Feng has fixed the issue: https://gcc.gnu.org/pipermail/gcc-patches/2024-January/641903.html It's just a pretty s

Re: Re: [committed] RISC-V: Add crypto vector builtin function.

2024-01-04 Thread Feng Wang
; Kito.cheng Subject: Re: Re: [committed] RISC-V: Add crypto vector builtin function. We (me and kito) has reviewed vector-crypto. I believe Wang Feng has done && passed the regression (with no RTL check), but he just didn't enable RTL check I guessed. (By default, RTL check is disabled

Re: Re: [committed] RISC-V: Add crypto vector builtin function.

2024-01-04 Thread juzhe.zh...@rivai.ai
I have reverted those 2 commits: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=960c2620db254a1edc2cd61e608df73073b3de0d https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b3ec98d458f2b285bb7b3fa4fcd93fd830fee069 juzhe.zh...@rivai.ai From: Palmer Dabbelt Date: 2024-01-05 11:24 To: juzhe.zhong

Re: Re: [committed] RISC-V: Add crypto vector builtin function.

2024-01-04 Thread juzhe.zh...@rivai.ai
We (me and kito) has reviewed vector-crypto. I believe Wang Feng has done && passed the regression (with no RTL check), but he just didn't enable RTL check I guessed. (By default, RTL check is disabled in riscv-gnu-toolchain, developers need to enable it manually). It's ok to revert the patch,