Re: Re: [PATCH] VECT: Support CALL vectorization for COND_LEN_*

2023-07-25 Thread juzhe.zh...@rivai.ai
Hi, Richard. >> I think we should have an internal-fn helper that returns IFN_COND_LEN_* >> for a given IFN_COND_*. It could handle IFN_MASK_LOAD -> IFN_MASK_LEN_LOAD >> etc. too. Could you name this helper function for me? Does it call "get_conditional_len_internal_fn_for_conditional_fn" ? Than

Re: Re: [PATCH] VECT: Support CALL vectorization for COND_LEN_*

2023-07-25 Thread juzhe.zh...@rivai.ai
Thanks Richard. Do you suggest we should add a macro like this first: #ifndef DEF_INTERNAL_COND_FN #define DEF_INTERNAL_COND_FN(NAME, FLAGS, OPTAB, TYPE) \ DEF_INTERNAL_OPTAB_FN (COND_##NAME, FLAGS, cond_##optab, cond_##TYPE) DEF_INTERNAL_OPTAB_FN (COND_LEN_##NAME, FLAGS, cond_len_##optab, co

Re: Re: [PATCH] VECT: Support CALL vectorization for COND_LEN_*

2023-07-24 Thread 钟居哲
Hi, Richi. Thank you so much for review. >> This function doesn't seem to care about conditional vectorization >> support, so why are you changing it? I debug and analyze the code here: Breakpoint 1, vectorizable_call (vinfo=0x3d358d0, stmt_info=0x3dcc820, gsi=0x0, vec_stmt=0x0, slp_node=0x0, c