Re: Re: [PATCH] RISC-V: Refactor the framework of RVV auto-vectorization

2023-05-23 Thread juzhe.zh...@rivai.ai
o Cheng Date: 2023-05-23 16:45 To: juzhe.zh...@rivai.ai CC: Robin Dapp; gcc-patches; Kito.cheng; palmer; palmer; jeffreyalaw Subject: Re: Re: [PATCH] RISC-V: Refactor the framework of RVV auto-vectorization > ARM uses rtx operands[] in many places and I personally prefer this way since > it will

Re: Re: [PATCH] RISC-V: Refactor the framework of RVV auto-vectorization

2023-05-23 Thread Kito Cheng via Gcc-patches
> ARM uses rtx operands[] in many places and I personally prefer this way since > it will make codes much cleaner. > I dislike the way making the function argument with multiple operand ,like > this: > void func(rtx dest, rtx src1, rtx src2, ) > If we are doing this, we will need to add helper

Re: Re: [PATCH] RISC-V: Refactor the framework of RVV auto-vectorization

2023-05-23 Thread juzhe.zh...@rivai.ai
Hi, Robin. >> Why does a store not have a destination (as commented below)? OK, V2 patch will have more comments. >> m_all_unmasked_p or m_fully_unmasked_p? OK. >> Apart from the insn-centric name, couldn't we also decide this >> based on the context later? In the vector-builtins.cc we have >>