Re: Re: [PATCH] RISC-V: Add rawmemchr expander.

2023-10-27 Thread 钟居哲
It seems that you didn't commit it yet. A nit comment: + int lmul = riscv_autovec_lmul == RVV_DYNAMIC ? RVV_M8 : riscv_autovec_lmul; I change you could use TARGET_MAX_LMUL https://gcc.gnu.org/git/?p=gcc.git;a=blobdiff;f=gcc/config/riscv/riscv-opts.h;h=532b1b6b84a0fff7d4755507cef32193276c0c3f;hp=

Re: Re: [PATCH] RISC-V: Add rawmemchr expander.

2023-10-27 Thread juzhe.zh...@rivai.ai
I notice we have expand_block_move in riscv-v.cc Maybe we should move it into riscv-string.cc ? juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-10-27 15:51 To: Kito Cheng; juzhe.zh...@rivai.ai CC: rdapp.gcc; gcc-patches; palmer; jeffreyalaw Subject: Re: [PATCH] RISC-V: Add rawmemchr expander

Re: Re: [PATCH] RISC-V: Add rawmemchr expander.

2023-10-27 Thread Kito Cheng
Could you put it into riscv-string.cc rather than riscv-v.cc? I would like to put those builtin function expander together if possible, riscv-string.cc might little bit confuse, but it's all included in string.h On Fri, Oct 27, 2023 at 3:40 PM juzhe.zh...@rivai.ai wrote: > > LGTM. Thanks. > > ___

Re: Re: [PATCH] RISC-V: Add rawmemchr expander.

2023-10-27 Thread juzhe.zh...@rivai.ai
LGTM. Thanks. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-10-27 15:38 To: 钟居哲; gcc-patches; palmer; kito.cheng; Jeff Law CC: rdapp.gcc Subject: Re: [PATCH] RISC-V: Add rawmemchr expander. > Suggested adapt codes as follows: > > unsigned int element_size = GET_MODE_SIZE (mode).to_constant