Re: RFA: PATCH to allow DECL_COMDAT_GROUP to be a DECL

2014-05-27 Thread Jan Hubicka
> On 05/19/2014 06:10 PM, Jan Hubicka wrote: > >Instead of adding extra loop over whole symtab, what about converting them > >at a time > >the symbols are inserted into the symbol table or in > >function_and_variable_visibility > >that already does quite few changes into various flags? > > Conve

Re: RFA: PATCH to allow DECL_COMDAT_GROUP to be a DECL

2014-05-27 Thread Jason Merrill
On 05/19/2014 06:10 PM, Jan Hubicka wrote: Instead of adding extra loop over whole symtab, what about converting them at a time the symbols are inserted into the symbol table or in function_and_variable_visibility that already does quite few changes into various flags? Converting them during

Re: RFA: PATCH to allow DECL_COMDAT_GROUP to be a DECL

2014-05-19 Thread Jan Hubicka
> I was playing around with this a few months ago but set it aside > because we weren't in stage 1 at the time. The way we currently set > up comdat groups early means that we need to mangle decls early, > significantly negating the earlier work to lazily set > DECL_ASSEMBLER_NAME. This patch imp