Re: Patch I have Formatted in Git

2017-09-29 Thread nick
On 2017-09-29 04:25 PM, Joseph Myers wrote: > On Fri, 29 Sep 2017, nick wrote: > >> - error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason); >> + error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", N_(reason)); > > This can't be right. N_ only makes sense around a str

Re: Patch I have Formatted in Git

2017-09-29 Thread Joseph Myers
On Fri, 29 Sep 2017, nick wrote: > - error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason); > + error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", N_(reason)); This can't be right. N_ only makes sense around a string literal (e.g. in a constant initializer); it marks