Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
On Wed, 5 Jun 2019 at 19:19, Jason Merrill wrote: > On 6/5/19 1:29 PM, Nina Dinka Ranns wrote: > > Ack. Amended change log is below. Changes are : > > * changed C++ -> c++ > > * fixed the name of added test > > > > There are no changes in the diff, but I attached it to this e-mail for > > referen

Re: PR C++/63149

2019-06-05 Thread Jason Merrill
On 6/5/19 1:29 PM, Nina Dinka Ranns wrote: Ack. Amended change log is below. Changes are : * changed C++ -> c++ * fixed the name of added test There are no changes in the diff, but I attached it to this e-mail for reference. Applied, thanks! For future reference it's also customary to add a b

Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
Ack. Amended change log is below. Changes are : * changed C++ -> c++ * fixed the name of added test There are no changes in the diff, but I attached it to this e-mail for reference. Thanks, Nina 2019-06-04 Nina Dinka Ranns gcc/cp PR c++/63149 * pt.c (listify_autos): Use non cv qu

Re: PR C++/63149

2019-06-05 Thread Marek Polacek
On Wed, Jun 05, 2019 at 02:50:54PM +0200, Jakub Jelinek wrote: > On Wed, Jun 05, 2019 at 08:39:56AM -0400, Marek Polacek wrote: > > On Wed, Jun 05, 2019 at 10:34:05AM +0100, Nina Dinka Ranns wrote: > > > > PR C++/63149 > > > > * pt.c (listify_autos): Use non cv qualified auto_node in > > >

Re: PR C++/63149

2019-06-05 Thread Jakub Jelinek
On Wed, Jun 05, 2019 at 08:39:56AM -0400, Marek Polacek wrote: > On Wed, Jun 05, 2019 at 10:34:05AM +0100, Nina Dinka Ranns wrote: > > > PR C++/63149 > > > * pt.c (listify_autos): Use non cv qualified auto_node in > > > std::initializer_list. > > > > > > testsuite/ > > > > > > P

Re: PR C++/63149

2019-06-05 Thread Marek Polacek
On Wed, Jun 05, 2019 at 10:34:05AM +0100, Nina Dinka Ranns wrote: > > PR C++/63149 > > * pt.c (listify_autos): Use non cv qualified auto_node in > > std::initializer_list. > > > > testsuite/ > > > > PR C++/63149 "c++" instead of "C++", thought I don't think anyone would mind.

Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
yes, I forgot to attach the latest patch. :) On Wed, 5 Jun 2019 at 10:24, Nina Dinka Ranns wrote: > > Hi both, > Addressing all comments in this e-mail, as some are duplicate. > > On Tue, 4 Jun 2019 at 20:45, Paolo Carlini wrote: > > > > Hi, > > > > On 04/06/19 21:26, Nina Dinka Ranns wrote: > >

Re: PR C++/63149

2019-06-05 Thread Nina Dinka Ranns
Hi both, Addressing all comments in this e-mail, as some are duplicate. On Tue, 4 Jun 2019 at 20:45, Paolo Carlini wrote: > > Hi, > > On 04/06/19 21:26, Nina Dinka Ranns wrote: > > Good point, dg-do compile is sufficient to demonstrate the issue. > > I agree. > > A couple of additional nits, sorr

Re: PR C++/63149

2019-06-04 Thread Jakub Jelinek
On Tue, Jun 04, 2019 at 08:26:58PM +0100, Nina Dinka Ranns wrote: ChangeLog entry is missing. > Index: gcc/cp/pt.c > === > --- gcc/cp/pt.c (revision 271709) > +++ gcc/cp/pt.c (working copy) > @@ -26836,7 +26836,7 @@ > st

Re: PR C++/63149

2019-06-04 Thread Paolo Carlini
Hi, On 04/06/19 21:26, Nina Dinka Ranns wrote: Good point, dg-do compile is sufficient to demonstrate the issue. I agree. A couple of additional nits, sorry for mentioning only now. C++63149_2.diff Index: gcc/cp/pt.c === ---

Re: PR C++/63149

2019-06-04 Thread Nina Dinka Ranns
Good point, dg-do compile is sufficient to demonstrate the issue. Amended, new patch attached. Thanks, Nina On Tue, 4 Jun 2019 at 17:53, Paolo Carlini wrote: > > Hi, > > On 04/06/19 18:36, Nina Dinka Ranns wrote: > > +// Test for PR63149 > > +// { dg-do run { target c++11 } } > > Are you sure you

Re: PR C++/63149

2019-06-04 Thread Paolo Carlini
Hi, On 04/06/19 18:36, Nina Dinka Ranns wrote: +// Test for PR63149 +// { dg-do run { target c++11 } } Are you sure you want a dg-do run? Paolo.