Re: PING^2: [PATCH] Support -fuse-ld=bfd and -fuse-ld=gold

2013-01-07 Thread Joseph S. Myers
On Wed, 19 Dec 2012, H.J. Lu wrote: > +#ifdef CROSS_DIRECTORY_STRUCTURE > + = concat(target_machine, "-", ld_suffixes[i], NULL); Missing space before '('. The patch is OK with that fixed. -- Joseph S. Myers jos...@codesourcery.com

Re: PING^2: [PATCH] Support -fuse-ld=bfd and -fuse-ld=gold

2012-12-19 Thread H.J. Lu
On Wed, Dec 19, 2012 at 1:13 PM, Joseph S. Myers wrote: > On Thu, 13 Dec 2012, H.J. Lu wrote: > >> Hi Joseph, >> >> Can you review this? > > I'm still confused as to what's supposed to be reviewed and whether the > issues raised in the previous discussions have been properly addressed. > Looking a

Re: PING^2: [PATCH] Support -fuse-ld=bfd and -fuse-ld=gold

2012-12-19 Thread Joseph S. Myers
On Thu, 13 Dec 2012, H.J. Lu wrote: > Hi Joseph, > > Can you review this? I'm still confused as to what's supposed to be reviewed and whether the issues raised in the previous discussions have been properly addressed. Looking at , I do