Re: PATCH [5/n] X32: Fix x32 trampoline

2011-07-10 Thread Richard Henderson
On 07/10/2011 12:45 PM, H.J. Lu wrote: > * config/i386/i386.c (ix86_trampoline_init): Use movl instead > of movabs for x32. Ok. r~

Re: PATCH [5/n] X32: Fix x32 trampoline

2011-07-10 Thread H.J. Lu
On Sat, Jul 9, 2011 at 6:20 PM, H.J. Lu wrote: > On Sat, Jul 9, 2011 at 4:12 PM, Richard Henderson wrote: >> On 07/09/2011 04:05 PM, H.J. Lu wrote: Is this change actually necessary?  I would think that the predicate has already been adjusted... >>> >>> Since we always use short ve

Re: PATCH [5/n] X32: Fix x32 trampoline

2011-07-09 Thread H.J. Lu
On Sat, Jul 9, 2011 at 4:12 PM, Richard Henderson wrote: > On 07/09/2011 04:05 PM, H.J. Lu wrote: >>> Is this change actually necessary?  I would think that the >>> predicate has already been adjusted... >>> >> >> Since we always use short version for x32, there is no need to call. >> x86_64_zext_

Re: PATCH [5/n] X32: Fix x32 trampoline

2011-07-09 Thread Richard Henderson
On 07/09/2011 04:05 PM, H.J. Lu wrote: >> Is this change actually necessary? I would think that the >> predicate has already been adjusted... >> > > Since we always use short version for x32, there is no need to call. > x86_64_zext_immediate_operand. Yes, but using the shorter condition, i.e. al

Re: PATCH [5/n] X32: Fix x32 trampoline

2011-07-09 Thread H.J. Lu
On Sat, Jul 9, 2011 at 3:46 PM, Richard Henderson wrote: > On 07/09/2011 02:41 PM, H.J. Lu wrote: >> Hi, >> >> X32 uses movl instead of movabs for trampoline.  OK for trunk? >> >> Thanks. >> >> H.J. >> --- >> 2011-07-09  H.J. Lu   >> >>       * config/i386/i386.c (ix86_trampoline_init): Use movl i

Re: PATCH [5/n] X32: Fix x32 trampoline

2011-07-09 Thread H.J. Lu
On Sat, Jul 9, 2011 at 3:46 PM, Richard Henderson wrote: > On 07/09/2011 02:41 PM, H.J. Lu wrote: >> Hi, >> >> X32 uses movl instead of movabs for trampoline.  OK for trunk? >> >> Thanks. >> >> H.J. >> --- >> 2011-07-09  H.J. Lu   >> >>       * config/i386/i386.c (ix86_trampoline_init): Use movl i

Re: PATCH [5/n] X32: Fix x32 trampoline

2011-07-09 Thread Richard Henderson
On 07/09/2011 02:41 PM, H.J. Lu wrote: > Hi, > > X32 uses movl instead of movabs for trampoline. OK for trunk? > > Thanks. > > H.J. > --- > 2011-07-09 H.J. Lu > > * config/i386/i386.c (ix86_trampoline_init): Use movl instead > of movabs for x32. > > diff --git a/gcc/config/i386