Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Michael Collison
Andrew, Yes it appears those are the three offenders. I like the approach of moving them to fold-const.c and exporting from fold-const.h. I will try that approach. On 12/19/2014 02:10 PM, Andrew MacLeod wrote: On 12/19/2014 03:46 PM, Michael Collison wrote: The reason I included tree-core.h

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 03:46 PM, Michael Collison wrote: The reason I included tree-core.h in all the .c files was the requirement in tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are inline functions such as fold_build_pointer_plus_hwi_loc which reference functions in fold-c

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Prathamesh Kulkarni
On 20 December 2014 at 02:16, Michael Collison wrote: > The reason I included tree-core.h in all the .c files was the requirement in > tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are > inline functions such as fold_build_pointer_plus_hwi_loc which reference > functions

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Michael Collison
The reason I included tree-core.h in all the .c files was the requirement in tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are inline functions such as fold_build_pointer_plus_hwi_loc which reference functions in fold-const.h. The moment you include fold-const.h you r

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 01:12 PM, Richard Biener wrote: On December 19, 2014 2:44:00 PM CET, Andrew MacLeod wrote: On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Archi

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Richard Biener
On December 19, 2014 2:44:00 PM CET, Andrew MacLeod wrote: >On 12/19/2014 06:20 AM, Richard Biener wrote: >> On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison >> wrote: >>> This patch flattens tree.h and tree-core.h. This work is part of the >GCC >>> Re-Architecture effort being led by Andrew Ma

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 08:44 AM, Andrew MacLeod wrote: On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. I removed the inc

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. I removed the includes in tree.h and tree-core.h except for the i

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Richard Biener
On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: > This patch flattens tree.h and tree-core.h. This work is part of the GCC > Re-Architecture effort being led by Andrew MacLeod. > > I removed the includes in tree.h and tree-core.h except for the include of > tree-core.h in tree.h. > > I mo