Re: Fix for PR70909 in Libiberty Demangler (4)

2016-07-17 Thread Marcel Böhme
Hi, This patch is still pending a full review. Best regards, - Marcel > On 30 Jun 2016, at 12:09 AM, Pedro Alves wrote: > > On 06/29/2016 08:43 AM, Marcel Böhme wrote: >> Hi Jason, >> >> These test cases are generated by fuzzing which produces a lot of >> nonsensical input data. >> I think,

Re: Fix for PR70909 in Libiberty Demangler (4)

2016-06-29 Thread Pedro Alves
On 06/29/2016 08:43 AM, Marcel Böhme wrote: > Hi Jason, > > These test cases are generated by fuzzing which produces a lot of nonsensical > input data. > I think, "Garbage In, Garbage Out" is quite applicable here. > With the patch at least it doesn’t crash and fixes the vulnerability. Note tha

Re: Fix for PR70909 in Libiberty Demangler (4)

2016-06-29 Thread Marcel Böhme
Hi Jason, These test cases are generated by fuzzing which produces a lot of nonsensical input data. I think, "Garbage In, Garbage Out" is quite applicable here. With the patch at least it doesn’t crash and fixes the vulnerability. Best regards, - Marcel > On 26 May 2016, at 10:05 PM, Jason Mer

Re: Fix for PR70909 in Libiberty Demangler (4)

2016-05-26 Thread Jason Merrill
It seems like in cases of malformed input we should return the input again rather than produce garbage like "K". Maybe catch this sort of situation in d_lookup_template_parameter? Jason On Mon, May 2, 2016 at 11:21 AM, Marcel Böhme wrote: > Hi, > > This fixes several stack overflows due to inf

Re: Fix for PR70909 in Libiberty Demangler (4)

2016-05-26 Thread Marcel Böhme
Hi, This patch is pending a careful review. Best regards, - Marcel > On 2 May 2016, at 11:21 PM, Marcel Böhme wrote: > > Hi, > > This fixes several stack overflows due to infinite recursion in d_print_comp > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70909). > > The method d_print_comp i