Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc

2015-05-15 Thread Jeff Law
On 05/15/2015 12:39 PM, Eric Botcazou wrote: You might consider a comment in active_insn_p and emit_pattern_{after,before}_setloc so that if someone fixes active_insn_p, they'll know to fix emit_pattern_{after,before}_setloc. "FIXME" doesn't capture this interaction at all ;-) I beg to differ,

Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc

2015-05-15 Thread Eric Botcazou
> You might consider a comment in active_insn_p and > emit_pattern_{after,before}_setloc so that if someone fixes > active_insn_p, they'll know to fix emit_pattern_{after,before}_setloc. > "FIXME" doesn't capture this interaction at all ;-) I beg to differ, it's the same file and anyone fiddling w

Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc

2015-05-14 Thread Jeff Law
On 05/11/2015 04:10 PM, Eric Botcazou wrote: This fixes an RTL checking failure I ran into while working on a change and it is latent in the pristine compiler. emit_pattern_{after|before}_setloc have: if (active_insn_p (after) && !INSN_LOCATION (after)) if (active_insn_p (first) && !INSN