Re: Fallout: PR84340

2018-02-16 Thread Jakub Jelinek
On Fri, Feb 16, 2018 at 11:58:07AM +0100, Martin Liška wrote: > Btw. do we want such patch to be backported? No. Jakub

Re: Fallout: PR84340

2018-02-16 Thread Martin Liška
On 02/16/2018 10:55 AM, Jakub Jelinek wrote: > On Fri, Feb 16, 2018 at 10:53:58AM +0100, Martin Liška wrote: >> Hi. >> >> I'm sending patch that does what Jakub suggested. >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. >> I consider the previous email as approval and

Re: Fallout: PR84340

2018-02-16 Thread Jakub Jelinek
On Fri, Feb 16, 2018 at 10:53:58AM +0100, Martin Liška wrote: > Hi. > > I'm sending patch that does what Jakub suggested. > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > I consider the previous email as approval and I'm going to install the patch. Ok, thanks. > >Fr

Re: Fallout: PR84340

2018-02-16 Thread Martin Liška
Hi. I'm sending patch that does what Jakub suggested. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. I consider the previous email as approval and I'm going to install the patch. Thanks, Martin >From b306ad522ed0f8a010647d0eb1d9c36b102e92c3 Mon Sep 17 00:00:00 2001 Fro

Re: Fallout: PR84340

2018-02-13 Thread Martin Liška
On 02/13/2018 04:22 PM, Paolo Bonzini wrote: On 13/02/2018 14:35, Jakub Jelinek wrote: On Tue, Feb 13, 2018 at 12:21:55PM +0100, Jakub Jelinek wrote: On Tue, Feb 13, 2018 at 12:15:36PM +0100, Paolo Bonzini wrote: The issue is that the ASAN_CHECK doesn't exist at early DSE time, and thus causes

Re: Fallout: PR84340

2018-02-13 Thread Paolo Bonzini
On 13/02/2018 14:35, Jakub Jelinek wrote: > On Tue, Feb 13, 2018 at 12:21:55PM +0100, Jakub Jelinek wrote: >> On Tue, Feb 13, 2018 at 12:15:36PM +0100, Paolo Bonzini wrote: >>> The issue is that the ASAN_CHECK doesn't exist at early DSE time, and >>> thus causes the store to disappear. >> >> If it

Re: Fallout: PR84340

2018-02-13 Thread Jakub Jelinek
On Tue, Feb 13, 2018 at 12:21:55PM +0100, Jakub Jelinek wrote: > On Tue, Feb 13, 2018 at 12:15:36PM +0100, Paolo Bonzini wrote: > > On 13/02/2018 10:32, Martin Liška wrote: > > > Hello. > > > > > > It caused PR84340, I'm suggesting following fix: > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=

Re: Fallout: PR84340

2018-02-13 Thread Jakub Jelinek
On Tue, Feb 13, 2018 at 12:15:36PM +0100, Paolo Bonzini wrote: > On 13/02/2018 10:32, Martin Liška wrote: > > Hello. > > > > It caused PR84340, I'm suggesting following fix: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84340#c3 > > I don't think EAF_DIRECT is the issue. You could think of AS

Re: Fallout: PR84340

2018-02-13 Thread Paolo Bonzini
On 13/02/2018 10:32, Martin Liška wrote: > Hello. > > It caused PR84340, I'm suggesting following fix: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84340#c3 I don't think EAF_DIRECT is the issue. You could think of ASAN_MARK as writing a global variable, which it can do because it's not const.