Re: Do not give realistic estimates for loop with array accesses

2016-04-07 Thread Tom de Vries
On 30/03/16 14:36, Richard Biener wrote: On Wed, 30 Mar 2016, Jan Hubicka wrote: > > > >You are only changing one place in this file. > >You are right. I am attaching the updated patch which I am re-testing now. > > > >The vectorizer already checks this (albeit indirectly): > > > > HOST_WID

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Bernhard Reutner-Fischer
On March 30, 2016 2:36:14 PM GMT+02:00, Richard Biener wrote: >On Wed, 30 Mar 2016, Jan Hubicka wrote: > >> > >> > You are only changing one place in this file. >> >> You are right. I am attaching the updated patch which I am re-testing >now. >> > >> > The vectorizer already checks this (albei

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Bin.Cheng
On Wed, Mar 30, 2016 at 3:22 PM, Jan Hubicka wrote: >> > - /* If access is not executed on every iteration, we must ensure that >> > overlow may >> > - not make the access valid later. */ >> > + /* If access is not executed on every iteration, we must ensure that >> > overlow >> > + m

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Jan Hubicka
> > - /* If access is not executed on every iteration, we must ensure that > > overlow may > > - not make the access valid later. */ > > + /* If access is not executed on every iteration, we must ensure that > > overlow > > + may not make the access valid later. */ > >if (!dominat

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Bin.Cheng
On Wed, Mar 30, 2016 at 11:00 AM, Jan Hubicka wrote: > Hi, > while looking into sudoku solving benchark, I noticed that we incorrectly > estimate loop to iterate 10 times just because the array it traverses is of > dimension 10. This of course is just upper bound and not realistic bound. > Realist

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Richard Biener
On Wed, 30 Mar 2016, Jan Hubicka wrote: > > > > You are only changing one place in this file. > > You are right. I am attaching the updated patch which I am re-testing now. > > > > The vectorizer already checks this (albeit indirectly): > > > > HOST_WIDE_INT max_niter > > = max_stmt_exec

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Jan Hubicka
> > You are only changing one place in this file. You are right. I am attaching the updated patch which I am re-testing now. > > The vectorizer already checks this (albeit indirectly): > > HOST_WIDE_INT max_niter > = max_stmt_executions_int (LOOP_VINFO_LOOP (loop_vinfo)); > if ((LOOP_VI

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Richard Biener
On Wed, 30 Mar 2016, Jan Hubicka wrote: > Hi, > while looking into sudoku solving benchark, I noticed that we incorrectly > estimate loop to iterate 10 times just because the array it traverses is of > dimension 10. This of course is just upper bound and not realistic bound. > Realistically those