Re: Comdat-aware code coverage data

2012-01-23 Thread Xinliang David Li
On Mon, Jan 23, 2012 at 12:52 PM, Nathan Sidwell wrote: > On 01/20/12 22:41, Xinliang David Li wrote: >> >> Nathan, I just noticed this path. This is a good improvement over the >> existing scheme. >> >> I see one potential problem with the patch -- different instances of >> the same comdat functi

Re: Comdat-aware code coverage data

2012-01-23 Thread Nathan Sidwell
On 01/20/12 22:41, Xinliang David Li wrote: Nathan, I just noticed this path. This is a good improvement over the existing scheme. I see one potential problem with the patch -- different instances of the same comdat function can potentially have different control flows (due to differences in ear

Re: Comdat-aware code coverage data

2012-01-20 Thread Xinliang David Li
Looks like the change to put fn_info and counter vars into comdat section is reverted due to regression. Assuming the comdat changes are kept, I don't see the point of doing fn data buffering -- it is certainly important to compare the key with the current gcov_info to avoid merging to happen mult

Re: Comdat-aware code coverage data

2012-01-20 Thread Xinliang David Li
Nathan, I just noticed this path. This is a good improvement over the existing scheme. I see one potential problem with the patch -- different instances of the same comdat function can potentially have different control flows (due to differences in early inline, early optimizations in different mo