Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-15 Thread Richard Henderson
On 11/14/2011 11:56 AM, Alan Modra wrote: > * function.c (thread_prologue_and_epilogue_insns): Guard > emitting return with single_succ_p test. Ok. r~

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread David Miller
From: Bernd Schmidt Date: Tue, 15 Nov 2011 01:54:34 +0100 > On 11/15/11 01:43, Richard Henderson wrote: >> On 11/14/2011 11:56 AM, Alan Modra wrote: >>> * function.c (thread_prologue_and_epilogue_insns): Guard >>> emitting return with single_succ_p test. >> >> Hmm. This looks plausible

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Bernd Schmidt
On 11/15/11 01:43, Richard Henderson wrote: > On 11/14/2011 11:56 AM, Alan Modra wrote: >> * function.c (thread_prologue_and_epilogue_insns): Guard >> emitting return with single_succ_p test. > > Hmm. This looks plausible too. > > Bernd's patch made sure that cfglayout didn't do some

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Richard Henderson
On 11/14/2011 11:56 AM, Alan Modra wrote: > On Mon, Nov 14, 2011 at 07:48:03AM -1000, Richard Henderson wrote: >> On 11/14/2011 04:10 AM, Hans-Peter Nilsson wrote: >>> Looks like all we need is a positive review of >>> and a >>> ChangeLog en

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Hans-Peter Nilsson
> From: Alan Modra > Date: Mon, 14 Nov 2011 22:56:48 +0100 > I haven't really looked into what Bernd's fix does. I know this one > fixes what I broke.. Hm... Oh well, I'm trusting RTH and Bernd that it fixed a real issue. Thanks for looking (and a belated thanks to RTH for the review). brgds,

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Hans-Peter Nilsson
> From: Richard Henderson > Date: Mon, 14 Nov 2011 18:48:03 +0100 > On 11/14/2011 04:10 AM, Hans-Peter Nilsson wrote: > > Looks like all we need is a positive review of > > and a > > ChangeLog entry to unbreak three or more targets. > > >

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Alan Modra
On Mon, Nov 14, 2011 at 07:48:03AM -1000, Richard Henderson wrote: > On 11/14/2011 04:10 AM, Hans-Peter Nilsson wrote: > > Looks like all we need is a positive review of > > and a > > ChangeLog entry to unbreak three or more targets. > > >

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Richard Henderson
On 11/14/2011 04:10 AM, Hans-Peter Nilsson wrote: > Looks like all we need is a positive review of > and a > ChangeLog entry to unbreak three or more targets. > > Someone with approval rights: pretty please? That patch is ok. r~

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Rainer Orth
Ramana Radhakrishnan writes: >> Someone with approval rights: pretty please? > > Can I add my +1 "pretty please" as well here :) ? According to #c3 > this fixes arm-linux-gnueabi cross-builds for C++ as well and > potentially allows this to bootstrap again. I have kicked off a > bootstrap and tes

Re: CFG review needed for fix of "PowerPC shrink-wrap support 3 of 3"

2011-11-14 Thread Ramana Radhakrishnan
> > Someone with approval rights: pretty please? Can I add my +1 "pretty please" as well here :) ? According to #c3 this fixes arm-linux-gnueabi cross-builds for C++ as well and potentially allows this to bootstrap again. I have kicked off a bootstrap and test run on arm-linux-gnueabi . cheers Ra