Re: C PATCH to use is_global_var

2015-06-25 Thread Jeff Law
On 06/25/2015 06:44 AM, Marek Polacek wrote: On Wed, Jun 24, 2015 at 05:16:33PM +, Joseph Myers wrote: On Wed, 24 Jun 2015, Marek Polacek wrote: diff --git gcc/c/c-decl.c gcc/c/c-decl.c index fc1fdf9..ab54db9 100644 --- gcc/c/c-decl.c +++ gcc/c/c-decl.c @@ -2650,9 +2650,8 @@ merge_decls (t

Re: C PATCH to use is_global_var

2015-06-25 Thread Marek Polacek
On Wed, Jun 24, 2015 at 05:16:33PM +, Joseph Myers wrote: > On Wed, 24 Jun 2015, Marek Polacek wrote: > > > diff --git gcc/c/c-decl.c gcc/c/c-decl.c > > index fc1fdf9..ab54db9 100644 > > --- gcc/c/c-decl.c > > +++ gcc/c/c-decl.c > > @@ -2650,9 +2650,8 @@ merge_decls (tree newdecl, tree olddecl

Re: C PATCH to use is_global_var

2015-06-24 Thread Joseph Myers
On Wed, 24 Jun 2015, Marek Polacek wrote: > diff --git gcc/c/c-decl.c gcc/c/c-decl.c > index fc1fdf9..ab54db9 100644 > --- gcc/c/c-decl.c > +++ gcc/c/c-decl.c > @@ -2650,9 +2650,8 @@ merge_decls (tree newdecl, tree olddecl, tree newtype, > tree oldtype) > tree_code_size (TREE_CODE

Re: C PATCH to use is_global_var

2015-06-24 Thread Jeff Law
On 06/24/2015 04:22 AM, Marek Polacek wrote: This patch makes the C FE use the predicate is_global_var in place of direct TREE_STATIC (t) || DECL_EXTERNAL (t) It should improve readability a bit and make predicates easier to follow. Bootstrapped/regtested on x86_64-linux, ok for trunk? 201