Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Jason Merrill
On Wed, Feb 13, 2019 at 4:03 PM Marek Polacek wrote: > On Wed, Feb 13, 2019 at 11:59:05AM -0500, Marek Polacek wrote: > > On Wed, Feb 13, 2019 at 11:44:42AM -0500, Jason Merrill wrote: > > > On 2/13/19 12:13 AM, Marek Polacek wrote: > > > > Here we ICE because we're in a template and the construct

Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Marek Polacek
On Wed, Feb 13, 2019 at 11:59:05AM -0500, Marek Polacek wrote: > On Wed, Feb 13, 2019 at 11:44:42AM -0500, Jason Merrill wrote: > > On 2/13/19 12:13 AM, Marek Polacek wrote: > > > Here we ICE because we're in a template and the constructor contains an > > > OVERLOAD, so calling check_narrowing -> m

Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Marek Polacek
On Wed, Feb 13, 2019 at 11:44:42AM -0500, Jason Merrill wrote: > On 2/13/19 12:13 AM, Marek Polacek wrote: > > Here we ICE because we're in a template and the constructor contains an > > OVERLOAD, so calling check_narrowing -> maybe_constant_value crashes. > > > > check_narrowing deliberately call

Re: C++ PATCH for c++/89297 - ICE with OVERLOAD in template

2019-02-13 Thread Jason Merrill
On 2/13/19 12:13 AM, Marek Polacek wrote: Here we ICE because we're in a template and the constructor contains an OVERLOAD, so calling check_narrowing -> maybe_constant_value crashes. check_narrowing deliberately calls maybe_constant_value and not fold_non_dependent_expr so as to avoid instantia