Re: Add -fpartial-profile-training

2019-12-05 Thread Jakub Jelinek
On Wed, Dec 04, 2019 at 10:52:28PM +0100, Jan Hubicka wrote: > * cgraphclones.c (localize_profile): New function. > (cgraph_node::create_clone): Use it for partial profiles. > * common.opt (fprofile-partial-training): New flag. This FAILs everywhere, with: Running /usr/src/gcc/gc

Re: Add -fpartial-profile-training

2019-12-05 Thread Richard Biener
On Thu, Dec 5, 2019 at 1:41 PM Martin Liška wrote: > > On 12/5/19 1:30 PM, Richard Biener wrote: > > I wonder if the behavior shouldn't be the default? The only thing we lose > > is failing to notice really cold calls (error paths) in programs? > > I would also consider enabling that by default.

Re: Add -fpartial-profile-training

2019-12-05 Thread Martin Liška
On 12/5/19 1:30 PM, Richard Biener wrote: I wonder if the behavior shouldn't be the default? The only thing we lose is failing to notice really cold calls (error paths) in programs? I would also consider enabling that by default. I'm sending a language correction for the option documentation:

Re: Add -fpartial-profile-training

2019-12-05 Thread Richard Biener
On Wed, Dec 4, 2019 at 10:52 PM Jan Hubicka wrote: > > Hi, > with recent fixes to proile updating I noticed that we get more regressions > compared to gcc 9 at Firefox testing. This is because Firefox train run is > not covering all the benchmarks and gcc 9, thanks to updating bugs sometimes > opt