Re: [pph] Add initial support for including nested pph images (issue4847044)

2011-08-10 Thread Diego Novillo
On Tue, Aug 9, 2011 at 20:52, Gabriel Charette wrote: > An ICE in lto_streamer_cache_get is not very intuitive to point out > the problem to the user in this case imo Right. > I'm thinking we should at least warn when some flags like this one > differ and when that difference has an impact

Re: [pph] Add initial support for including nested pph images (issue4847044)

2011-08-09 Thread Gabriel Charette
>>> Gah.  I was going to commit this separately but forgot.  Sorry about that. >>> >> K, why does this fix the test? seems weird that we had an infinite >> loop before and changing the flags gets rid of it? > > It wasn't an infinite loop but an ICE in the tree caches.  The > different options were

Re: [pph] Add initial support for including nested pph images (issue4847044)

2011-08-05 Thread Diego Novillo
On Fri, Aug 5, 2011 at 14:10, Gabriel Charette wrote: > On Fri, Aug 5, 2011 at 9:42 AM, Diego Novillo wrote: >> On Thu, Aug 4, 2011 at 17:47,   wrote: >>> So if I understand correctly, the reference system doesn't work yet, you >>> just put out the design in this patch and you'll fill up function

Re: [pph] Add initial support for including nested pph images (issue4847044)

2011-08-05 Thread Gabriel Charette
On Fri, Aug 5, 2011 at 9:42 AM, Diego Novillo wrote: > On Thu, Aug 4, 2011 at 17:47,   wrote: >> So if I understand correctly, the reference system doesn't work yet, you >> just put out the design in this patch and you'll fill up functionality >> in an upcoming patch so that's it's clearer what yo

Re: [pph] Add initial support for including nested pph images (issue4847044)

2011-08-05 Thread Diego Novillo
On Thu, Aug 4, 2011 at 17:47, wrote: > So if I understand correctly, the reference system doesn't work yet, you > just put out the design in this patch and you'll fill up functionality > in an upcoming patch so that's it's clearer what you're adding? Right, the 'if (0)' in pph_in_includes() disa

Re: [pph] Add initial support for including nested pph images (issue4847044)

2011-08-04 Thread gchare
So if I understand correctly, the reference system doesn't work yet, you just put out the design in this patch and you'll fill up functionality in an upcoming patch so that's it's clearer what you're adding? Cheers, Gab http://codereview.appspot.com/4847044/diff/1/gcc/cp/pph-streamer-in.c File