Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-21 Thread Gabriel Dos Reis
On Mon, Mar 21, 2011 at 3:33 AM, Kai Tietz wrote: > 2011/3/18 Jason Merrill : >> OK. >> >> Jason >> > > Applied first part at rev. 171209. Second part at rev. 171210. > thanks.

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-21 Thread Kai Tietz
2011/3/18 Jason Merrill : > OK. > > Jason > Applied first part at rev. 171209. Second part at rev. 171210. Kai

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-18 Thread Jason Merrill
OK. Jason

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Kai Tietz
2011/3/17 Jason Merrill : > On 03/17/2011 12:08 PM, Kai Tietz wrote: >> >> I thought to use here instead of on_diagnostic (which is IMHO fine too >> as it indicates for now only that attribute shall be displayed on >> diagnostics) "affects_abi". I think it makes sense to keep that name >> as short

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Jason Merrill
On 03/17/2011 12:08 PM, Kai Tietz wrote: I thought to use here instead of on_diagnostic (which is IMHO fine too as it indicates for now only that attribute shall be displayed on diagnostics) "affects_abi". I think it makes sense to keep that name as short as possible. Hmm, type compatibility is

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Kai Tietz
2011/3/17 Jason Merrill : > On 03/17/2011 04:46 AM, Kai Tietz wrote: >> >> PING, ok for 4.7? > > Did you have a response to my comment below? > >> 2011/1/4 Jason Merrill: >>> >>> On 01/01/2011 01:07 PM, Kai Tietz wrote: Well, as here no further agreement was found, I post here the al

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Jason Merrill
On 03/17/2011 04:46 AM, Kai Tietz wrote: PING, ok for 4.7? Did you have a response to my comment below? 2011/1/4 Jason Merrill: On 01/01/2011 01:07 PM, Kai Tietz wrote: Well, as here no further agreement was found, I post here the alternative suggested by Joseph. I am open-minded which app

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Kai Tietz
PING, ok for 4.7? 2011/1/4 Jason Merrill : > On 01/01/2011 01:07 PM, Kai Tietz wrote: >> >> Well, as here no further agreement was found, I post here the >> alternative suggested by Joseph. I am open-minded which approach will >> be chosen. I just want to fix this long pending issue. >> I split up