Re: [patch] Performance patch for MIPS conditional move in expr.c

2013-03-07 Thread Andrew Pinski
On Thu, Mar 7, 2013 at 7:12 AM, Jakub Jelinek wrote: > On Wed, Nov 14, 2012 at 02:22:33PM -0800, Andrew Pinski wrote: >> commit 8ca1e58de404bbe82b93bc240ef28c68c681243d >> Author: Andrew Pinski >> Date: Thu Jul 26 18:09:34 2012 -0700 >> >> 2012-07-26 Andrew Pinski >> >> Bug #3261 >

Re: [patch] Performance patch for MIPS conditional move in expr.c

2013-03-07 Thread Jakub Jelinek
On Wed, Nov 14, 2012 at 02:22:33PM -0800, Andrew Pinski wrote: > commit 8ca1e58de404bbe82b93bc240ef28c68c681243d > Author: Andrew Pinski > Date: Thu Jul 26 18:09:34 2012 -0700 > > 2012-07-26 Andrew Pinski > > Bug #3261 > * config/mips/mips.md (*mov_on_): > Remove m

Re: [patch] Performance patch for MIPS conditional move in expr.c

2013-01-07 Thread Steve Ellcey
On Thu, 2012-11-15 at 13:39 -0800, Andrew Pinski wrote: > > I was posting it for Steve's benefit really. I was in the process of > > updating the patch to the trunk and trying it out there before doing a > > formal submission :). As I found out the testcase needs to be changed > > to work with t

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-15 Thread Andrew Pinski
On Thu, Nov 15, 2012 at 1:24 PM, Andrew Pinski wrote: > On Thu, Nov 15, 2012 at 12:58 PM, Richard Sandiford > wrote: >> Andrew Pinski writes: >>> 2012-07-26 Andrew Pinski >>> >>> Bug #3261 >>> * config/mips/mips.md (*mov_on_): >>> Remove mode check from comparisons. >>>

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-15 Thread Andrew Pinski
On Thu, Nov 15, 2012 at 12:58 PM, Richard Sandiford wrote: > Andrew Pinski writes: >> 2012-07-26 Andrew Pinski >> >> Bug #3261 >> * config/mips/mips.md (*mov_on_): >> Remove mode check from comparisons. >> (*mov_on_): Likewise. >> (*mov_on__ne): New pattern to

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-15 Thread Richard Sandiford
Andrew Pinski writes: > 2012-07-26 Andrew Pinski > > Bug #3261 > * config/mips/mips.md (*mov_on_): > Remove mode check from comparisons. > (*mov_on_): Likewise. > (*mov_on__ne): New pattern to match > when (ne A 0) can be just A. > > * tes

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Richard Henderson
On 2012-11-14 11:02, Steve Ellcey wrote: > 2012-11-14 Steve Ellcey > > * expr.c (expand_cond_expr_using_cmove): Use promoted mode for temp. Ok. r~

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 1:51 PM, Andrew Pinski wrote: > On Wed, Nov 14, 2012 at 1:45 PM, Steve Ellcey wrote: >> On Wed, 2012-11-14 at 12:00 -0800, Andrew Pinski wrote: >> >>> I know exactly where this code comes from; I have looked at the >>> benchmark as one of the reason why I add expand_cond_e

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 1:45 PM, Steve Ellcey wrote: > On Wed, 2012-11-14 at 12:00 -0800, Andrew Pinski wrote: > >> I know exactly where this code comes from; I have looked at the >> benchmark as one of the reason why I add expand_cond_expr_using_cmove >> in the first place. Anyways you should lo

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
On Wed, 2012-11-14 at 12:00 -0800, Andrew Pinski wrote: > I know exactly where this code comes from; I have looked at the > benchmark as one of the reason why I add expand_cond_expr_using_cmove > in the first place. Anyways you should look into removing > TARGET_PROMOTE_PROTOTYPES because I found

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 11:27 AM, Steve Ellcey wrote: > On Wed, 2012-11-14 at 11:15 -0800, Andrew Pinski wrote: > >> Do you have a testcase? As I added expand_cond_expr_using_cmove, I >> think this is the correct fix. >> >> Thanks, >> Andrew Pinski > > Here is a cutdown test case that I have been

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Steve Ellcey
On Wed, 2012-11-14 at 11:15 -0800, Andrew Pinski wrote: > Do you have a testcase? As I added expand_cond_expr_using_cmove, I > think this is the correct fix. > > Thanks, > Andrew Pinski Here is a cutdown test case that I have been compiling with -O3, if you compare with and without my patch you

Re: [patch] Performance patch for MIPS conditional move in expr.c

2012-11-14 Thread Andrew Pinski
On Wed, Nov 14, 2012 at 11:02 AM, Steve Ellcey wrote: > > Back in August of 2011, Richard Biener made a change affecting COND_EXPRs > (r178408). As a result of that change the GCC MIPS compiler that used > to promote HImode variables to SImode and then put out SImode variables > and assignments f