Re: [patch] Fix segfault in param_change_prob

2016-09-01 Thread Richard Biener
On Thu, Sep 1, 2016 at 3:17 PM, Eric Botcazou wrote: >> So I think it's better to apply get_base_address here rather than only >> stripping VIEW_CONVERT_EXRPs. >> (beware of it returning NULL_TREE for WITH_SIZE_EXPRs, thus maybe >> strip those first as well) > > Something like this? The testsuite

Re: [patch] Fix segfault in param_change_prob

2016-09-01 Thread Eric Botcazou
> So I think it's better to apply get_base_address here rather than only > stripping VIEW_CONVERT_EXRPs. > (beware of it returning NULL_TREE for WITH_SIZE_EXPRs, thus maybe > strip those first as well) Something like this? The testsuite is still clean with it. * ipa-inline-analysis.c (p

Re: [patch] Fix segfault in param_change_prob

2016-09-01 Thread Richard Biener
On Wed, Aug 31, 2016 at 8:46 PM, Eric Botcazou wrote: > Hi, > > the attached Ada testcase triggers a segfault in param_change_prob because the > parameter is VIEW_CONVERT_EXPR (or it fools the logic and walk_aliased_vdefs is called on a NULL second argument > as the call is to a pure function. T