Re: [patch] Fix PR ada/35998

2013-11-13 Thread Richard Biener
On Mon, Nov 11, 2013 at 6:06 PM, Eric Botcazou wrote: >> Due to the different interfaces of int_size_in_bytes and >> simple_type_size_in_bits (and 'size' in add_byte_size_attribute being >> unsigned and not [unsigned] HWI) it would be cleaner to >> add an early return after the call to int_size_in

Re: [patch] Fix PR ada/35998

2013-11-11 Thread Eric Botcazou
> Due to the different interfaces of int_size_in_bytes and > simple_type_size_in_bits (and 'size' in add_byte_size_attribute being > unsigned and not [unsigned] HWI) it would be cleaner to > add an early return after the call to int_size_in_bytes if its > return value is -1 (and make sure the retur

Re: [patch] Fix PR ada/35998

2013-11-11 Thread Richard Biener
On Mon, Nov 11, 2013 at 11:10 AM, Eric Botcazou wrote: > Hi, > > this is an old bug report from Jan, which was closed, then reopened by Tom at > some point, but the patch never got reviewed. The original submission is at: > http://gcc.gnu.org/ml/gcc-patches/2008-05/msg01857.html > > Tested on x