Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-12 Thread FX
> Thanks everyone for the comments and review. > Committed as r217366 I cannot push the change to binutils-gdb as I don’t have write access there. Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS. Could someone do it for me? Thanks, FX

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Mike Stump
On Nov 11, 2014, at 11:48 AM, Jack Howarth wrote: > The only problem with this fix for the broken libtool.m4 is that > it will require constant tending as other patches regenerate these > various configure files. For example, > https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was jus

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
> Totally agree with Mike here. If you look at the patch it's clear it's just > hitting Darwin and it's absolutely safe. Thanks everyone for the comments and review. Committed as r217366 FX

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
Hi Jack, > The only problem with this fix for the broken libtool.m4 is that > it will require constant tending as other patches regenerate these > various configure files. As I explained in an earlier email today, you are mistaken about the patch. It does fix libtool.m4, which means that all fur

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jack Howarth
Mike, The only problem with this fix for the broken libtool.m4 is that it will require constant tending as other patches regenerate these various configure files. For example, https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was just committed would have removed the proposed change h

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jeff Law
On 11/11/14 12:38, Mike Stump wrote: 2014-11-11 Francois-Xavier Coudert PR target/63610 * configure: Missing Regenerate. OK to commit? Ok. This touches so many area it probably needs a build maintainer or global maintainer to approve it. Only darwin is affected, and unlikely anyone e

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Mike Stump
On Nov 11, 2014, at 11:06 AM, FX wrote: > Here’s v2 of the patch > OK to commit? Ok with comments: libvtv: libvtv/ 2014-11-11 Francois-Xavier Coudert PR target/63610 * configure: Missing Regenerate. > OK to commit? Ok. > This touches so many area it probably needs a bu