Re: [google 4.7] fdo build for linux kernel (issue 6968046)

2012-12-20 Thread Rong Xu
that's right. but there is no way to predict the pattern. what I meant was as far as it does not introduce major slow-down in dumping profile, I'd like to use the simpler version. what do you think? -Rong On Thu, Dec 20, 2012 at 11:54 AM, Xinliang David Li wrote: > It depends on the value distr

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

2012-12-20 Thread Xinliang David Li
It depends on the value distribution . David On Thu, Dec 20, 2012 at 11:30 AM, Rong Xu wrote: > On Wed, Dec 19, 2012 at 5:22 PM, Rong Xu wrote: >> On Wed, Dec 19, 2012 at 5:04 PM, wrote: >>> The change in gcov-io.h is from a different patch. >> >> sorry. here is the patch for gcov-io.h: >> >

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

2012-12-20 Thread Rong Xu
On Wed, Dec 19, 2012 at 5:22 PM, Rong Xu wrote: > On Wed, Dec 19, 2012 at 5:04 PM, wrote: >> The change in gcov-io.h is from a different patch. > > sorry. here is the patch for gcov-io.h: > > Index: gcov-io.h > === > --- gcov-io.h

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

2012-12-19 Thread Rong Xu
On Wed, Dec 19, 2012 at 5:04 PM, wrote: > The change in gcov-io.h is from a different patch. sorry. here is the patch for gcov-io.h: Index: gcov-io.h === --- gcov-io.h (revision 194562) +++ gcov-io.h (working copy) @@ -781,8 +7

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

2012-12-19 Thread davidxl
The change in gcov-io.h is from a different patch. David https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c File gcc/gcov-io.c (right): https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c#newcode688 gcc/gcov-io.c:688: Have you compared this with this impl: while (x) { c++;