Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-30 Thread Xinliang David Li
ok for google branches. David On Wed, Nov 30, 2011 at 6:09 AM, wrote: > On 2011/11/30 13:17:04, Diego Novillo wrote: >> >> On 11-11-30 03:53 , mailto:dvyu...@google.com wrote: >> > On 2011/11/14 16:48:45, davidxl wrote: >> >> Ok for google/main after compiler bootstrap and regression test >> >>

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-30 Thread Diego Novillo
On 11-11-30 03:53 , dvyu...@google.com wrote: On 2011/11/14 16:48:45, davidxl wrote: Ok for google/main after compiler bootstrap and regression test (without ftsan), and some large tests with tsan turned on (as many as you can but at your discretion). Hi David, Perhaps a bit late question...

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-14 Thread Xinliang David Li
Ok for google/main after compiler bootstrap and regression test (without ftsan), and some large tests with tsan turned on (as many as you can but at your discretion). David On Sun, Nov 13, 2011 at 11:59 PM, wrote: > On 2011/11/11 00:00:35, davidxl wrote: >> >> Have you run through SPEC, and SPE

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-10 Thread Xinliang David Li
On Thu, Nov 10, 2011 at 4:24 PM, Kostya Serebryany wrote: > > > On Thu, Nov 10, 2011 at 4:00 PM, wrote: >> >> Have you run through SPEC, and SPEC06 with this change? What is the >> instrumentation overhead using gcc? > > I don't think anyone of us ever run spec with tsan. > Mostly because this wi

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-10 Thread davidxl
Have you run through SPEC, and SPEC06 with this change? What is the instrumentation overhead using gcc? David http://codereview.appspot.com/5303083/

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-10 Thread davidxl
http://codereview.appspot.com/5303083/diff/28001/gcc/tree-tsan.c File gcc/tree-tsan.c (right): http://codereview.appspot.com/5303083/diff/28001/gcc/tree-tsan.c#newcode227 gcc/tree-tsan.c:227: var = varpool_node_for_asm (id); Use cgraph_node_for_asm instead. http://codereview.appspot.com/5303083

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-03 Thread Xinliang David Li
On Thu, Nov 3, 2011 at 6:31 AM, wrote: > On 2011/11/01 16:59:04, davidxl wrote: >> >> that means some existing bugs get exposed. > > It is quite likely. > >> Your previous version >> simply skipped the target mem refs. > > Hummm... how can non-handling of some expressions lead to crashes? I > wou

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-03 Thread Xinliang David Li
> http://codereview.appspot.com/5303083/diff/1/gcc/tree-tsan.c#newcode911 >> >> gcc/tree-tsan.c:911: bbd->has_sb = 0; >> Where is the code that instrument function calls? > > I do not instrument calls. Instead I instrument func entry/exit. > How are calls to locking and synchronization functions t

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-01 Thread Xinliang David Li
On Tue, Nov 1, 2011 at 12:26 PM, Martin Jambor wrote: > Hi, > > sorry that I'm not using the fancy web tool but I do not want to use > my google account and gmail address in particular for work-related > stuff. > > On Tue, Nov 01, 2011 at 06:05:46PM +, davi...@google.com wrote: >> > > ... > >>

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-01 Thread Diego Novillo
On 11-11-01 15:26 , Martin Jambor wrote: Hi, sorry that I'm not using the fancy web tool but I do not want to use my google account and gmail address in particular for work-related stuff. No worries. You do not need to use the web tool at all. You can simply reply to these messages. As lo

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-01 Thread Martin Jambor
Hi, sorry that I'm not using the fancy web tool but I do not want to use my google account and gmail address in particular for work-related stuff. On Tue, Nov 01, 2011 at 06:05:46PM +, davi...@google.com wrote: > ... > > http://codereview.appspot.com/5303083/diff/1/gcc/tree-tsan.c#newcode6

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-01 Thread davidxl
http://codereview.appspot.com/5303083/diff/1/gcc/tree-tsan.c File gcc/tree-tsan.c (right): http://codereview.appspot.com/5303083/diff/1/gcc/tree-tsan.c#newcode432 gcc/tree-tsan.c:432: /* Builds either (__tsan_shadow_stack += 1) or (__tsan_shadow_stack -= 1) expression Line too long. http://code

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-01 Thread davidxl
http://codereview.appspot.com/5303083/diff/3002/gcc/tree-tsan.c File gcc/tree-tsan.c (right): http://codereview.appspot.com/5303083/diff/3002/gcc/tree-tsan.c#newcode1075 gcc/tree-tsan.c:1075: for (eidx = 0; VEC_iterate (edge, exit_bb->preds, eidx, e); eidx++) Use FOR_EACH_EDGE macro http://code

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-11-01 Thread Xinliang David Li
that means some existing bugs get exposed. Your previous version simply skipped the target mem refs. You will need to debug the problem a little more. David On Tue, Nov 1, 2011 at 5:26 AM, wrote: > On 2011/10/31 06:08:34, davidxl wrote: >> >> http://codereview.appspot.com/5303083/diff/1/gcc/pa

Re: [google] ThreadSanitizer instrumentation pass (issue 5303083)

2011-10-30 Thread davidxl
Have not done with reviewing. This is the first batch. David http://codereview.appspot.com/5303083/diff/1/gcc/passes.c File gcc/passes.c (right): http://codereview.appspot.com/5303083/diff/1/gcc/passes.c#newcode1423 gcc/passes.c:1423: NEXT_PASS (pass_tsan); Move this to the same place as asan.