Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-11-06 Thread Alexander Monakov
On Fri, 6 Nov 2015, Bernd Schmidt wrote: > On 10/30/2015 05:44 PM, Alexander Monakov wrote: > > + /* Ignore "omp target entrypoint" here: OpenMP target region functions > > are > > + called from gomp_nvptx_main. The corresponding kernel entry is > > emitted > > + from write_omp_entry. */

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 03:08 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 03:05:05PM +0100, Bernd Schmidt wrote: This patch creates a new "omp target entrypoint" annotation that appears not to be used - it would be better to just not annotate a function if it's not going to need entrypoint treatment.

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-11-06 Thread Jakub Jelinek
On Fri, Nov 06, 2015 at 03:05:05PM +0100, Bernd Schmidt wrote: > This patch creates a new "omp target entrypoint" annotation that appears not > to be used - it would be better to just not annotate a function if it's not > going to need entrypoint treatment. IMO a single type of attribute should be

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-11-06 Thread Bernd Schmidt
On 10/30/2015 05:44 PM, Alexander Monakov wrote: + /* Ignore "omp target entrypoint" here: OpenMP target region functions are + called from gomp_nvptx_main. The corresponding kernel entry is emitted + from write_omp_entry. */ } I'm probably confused, but didn't we agree that this s

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-10-30 Thread Alexander Monakov
On Wed, 21 Oct 2015, Jakub Jelinek wrote: > > At the moment the attribute setting logic in omp-low.c is such that if a > > function that should be present in target code does not already have 'omp > > declare target' attribute, it receives 'omp target entrypoint'. That is > > wasteful: clearly not

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-10-21 Thread Jakub Jelinek
On Tue, Oct 20, 2015 at 09:34:27PM +0300, Alexander Monakov wrote: > (note to reviewers: I'm not sure what we're after here, on the high level; > will be happy to rework the patch in a saner manner based on feedback, or even > drop it for now) > > At the moment the attribute setting logic in omp-l

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-10-20 Thread Bernd Schmidt
On 10/20/2015 08:34 PM, Alexander Monakov wrote: (note to reviewers: I'm not sure what we're after here, on the high level; will be happy to rework the patch in a saner manner based on feedback, or even drop it for now) At the moment the attribute setting logic in omp-low.c is such that if a fun