On 21/07/15 12:19, Thomas Schwinge wrote:
Hi!
Thanks for the cleanup!
On Mon, 20 Jul 2015 11:54:48 +0200, Tom de Vries wrote:
On 19/07/15 23:08, Nathan Sidwell wrote:
On 07/19/15 16:30, Thomas Schwinge wrote:
Does it make sense then to rename GOACC_kernels_internal to
GOACC_kernels?
[...
Hi!
Thanks for the cleanup!
On Mon, 20 Jul 2015 11:54:48 +0200, Tom de Vries wrote:
> On 19/07/15 23:08, Nathan Sidwell wrote:
> > On 07/19/15 16:30, Thomas Schwinge wrote:
> >> Does it make sense then to rename GOACC_kernels_internal to
> >> GOACC_kernels?
> > [...] perhaps it should be an int
On 07/20/15 05:54, Tom de Vries wrote:
Turning it into an internal fn will make it harder to convert a
GOACC_kernels_internal call into a GOACC_parallel call, which we're doing here
I wondered ...
On 19/07/15 23:08, Nathan Sidwell wrote:
On 07/19/15 16:30, Thomas Schwinge wrote:
gcc/tree-parloops.c:/* Remove GOACC_kernels. */
libgomp/libgomp.map:GOACC_kernels;
libgomp/libgomp_g.h:extern void GOACC_kernels (int, void (*)
(void *), size_t,
I fixed all byt the parl
On 07/19/15 16:30, Thomas Schwinge wrote:
gcc/tree-parloops.c:/* Remove GOACC_kernels. */
libgomp/libgomp.map:GOACC_kernels;
libgomp/libgomp_g.h:extern void GOACC_kernels (int, void (*) (void *),
size_t,
I fixed all byt the parloops comment. That comment didn't really
On 19/07/15 22:30, Thomas Schwinge wrote:
Does it make sense then to rename GOACC_kernels_internal to
GOACC_kernels?
I prefer to keep the name GOACC_kernels_internal, IMO it's clearer.
Thanks,
- Tom
Hi!
On Sun, 19 Jul 2015 08:27:44 -0400, Nathan Sidwell wrote:
> Tom,
> as we discussed this patch removes the GOACC_kernels call, which forwards to
> GOACC_parallel. We simply call GOACC_parallel directly.
>
> ok for gomp4 branch?
> gcc/
> * omp-low.c (expand_omp_target): Convert
On 19/07/15 14:27, Nathan Sidwell wrote:
Tom,
as we discussed this patch removes the GOACC_kernels call, which
forwards to GOACC_parallel. We simply call GOACC_parallel directly.
ok for gomp4 branch?
Hi Nathan,
yes, that looks good.
Thanks,
- Tom
